Skip to content

Optimize away some path lookups in the generic fs::copy implementation #80755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 9, 2021
Merged

Optimize away some path lookups in the generic fs::copy implementation #80755

merged 1 commit into from
Jan 9, 2021

Conversation

@sunfishcode
Copy link
Member

@sunfishcode sunfishcode commented Jan 6, 2021

This also eliminates a use of a Path convenience function, in support
of #80741, refactoring std::path to focus on pure data structures and
algorithms.

@sunfishcode
Optimize away some path lookups in the generic fs::copy implementat…
97baac4 
…ion.

This also eliminates a use of a `Path` convenience function, in support
of rust-lang#80741, refactoring `std::path` to focus on pure data structures and
algorithms.
@rust-highfive
Copy link
Contributor

rust-highfive commented Jan 6, 2021

r? @joshtriplett

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 6, 2021
@sunfishcode sunfishcode mentioned this pull request Jan 6, 2021
Closed
@nagisa
Copy link
Member

nagisa commented Jan 7, 2021

@bors r+ r? @nagisa

@bors
Copy link
Collaborator

bors commented Jan 7, 2021

📌 Commit 97baac4 has been approved by nagisa

@rust-highfive rust-highfive assigned nagisa and unassigned joshtriplett Jan 7, 2021
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 7, 2021
@bors
Copy link
Collaborator

bors commented Jan 8, 2021

⌛ Testing commit 97baac4 with merge 44b63e0c534b32383594a1b1ce54afa01c630649...

@bors
Copy link
Collaborator

bors commented Jan 8, 2021

💔 Test failed - checks-actions

@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Jan 8, 2021

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jan 8, 2021
@nagisa
Copy link
Member

nagisa commented Jan 8, 2021

@bors retry r? @nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 8, 2021
@bors
Copy link
Collaborator

bors commented Jan 9, 2021

⌛ Testing commit 97baac4 with merge 1f9dc9a...

@bors
Copy link
Collaborator

bors commented Jan 9, 2021

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 1f9dc9a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 9, 2021
@bors bors merged commit 1f9dc9a into rust-lang:master Jan 9, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 9, 2021
@sunfishcode sunfishcode deleted the path-cleanup/copy branch November 5, 2021 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nagisa nagisa

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

1.51.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sunfishcode @rust-highfive @nagisa @bors @rust-log-analyzer @joshtriplett @rustbot