Skip to content

Conversation

@JulianKnodt
Copy link
Contributor

Remove some allocations & also add skip_current_subtree to skip subtrees with no inferred items.

r? @eddyb since marked in the FIXME

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 28, 2020
@jonas-schievink
Copy link
Contributor

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@bors
Copy link
Collaborator

bors commented Dec 28, 2020

⌛ Trying commit 690027c63747292a6e9892d6e695ab78f3dcbb1b with merge 84fa9d2d81ecada2009acc0e4984e4301bf5f721...

@bors
Copy link
Collaborator

bors commented Dec 28, 2020

☀️ Try build successful - checks-actions
Build commit: 84fa9d2d81ecada2009acc0e4984e4301bf5f721 (84fa9d2d81ecada2009acc0e4984e4301bf5f721)

@rust-timer
Copy link
Collaborator

Queued 84fa9d2d81ecada2009acc0e4984e4301bf5f721 with parent 2987785, future comparison URL.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 28, 2020
@rust-timer
Copy link
Collaborator

Finished benchmarking try commit (84fa9d2d81ecada2009acc0e4984e4301bf5f721): comparison url.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. Please note that if the perf results are neutral, you should likely undo the rollup=never given below by specifying rollup- to bors.

Importantly, though, if the results of this run are non-neutral do not roll this PR up -- it will mask other regressions or improvements in the roll up.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Dec 29, 2020
@crlf0710 crlf0710 added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 15, 2021
@JohnCSimon JohnCSimon added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2021
@JohnCSimon
Copy link
Member

ping from triage:
@JulianKnodt - can you please address the merge conflict?

@rustbot label: -S-waiting-on-review +S-waiting-on-author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 23, 2021
@JulianKnodt
Copy link
Contributor Author

@rustbot label: +S-waiting-on-review -S-waiting-on-author

@eddyb if you're too busy to review this can you assign it to someone else?

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 23, 2021
@eddyb
Copy link
Member

eddyb commented Feb 23, 2021

I am not in the review rotation anymore, sorry!

r? @matthewjasper or @nikomatsakis

@rust-highfive rust-highfive assigned matthewjasper and unassigned eddyb Feb 23, 2021
@matthewjasper
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

📌 Commit 899f27d has been approved by matthewjasper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 27, 2021
@bors
Copy link
Collaborator

bors commented Feb 27, 2021

⌛ Testing commit 899f27d with merge 94736c4...

@bors
Copy link
Collaborator

bors commented Feb 27, 2021

☀️ Test successful - checks-actions
Approved by: matthewjasper
Pushing 94736c4 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 27, 2021
@bors bors merged commit 94736c4 into rust-lang:master Feb 27, 2021
@rustbot rustbot added this to the 1.52.0 milestone Feb 27, 2021
@JulianKnodt JulianKnodt deleted the ob_forest_op branch February 27, 2021 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants