Fix inlining of glue code #7154
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when calling glue functions, we cast the function to match the argument type. This interacts very badly with LLVM and breaks inlining of the glue code. It's more efficient to use a unified function type for the glue functions and always cast the function argument instead of the function. The resulting code for rustc is about 13% faster (measured up to and including the "trans" pass) and the resulting librustc is about 5% smaller.
bors
added a commit
that referenced
this pull request
Jun 15, 2013
Currently, when calling glue functions, we cast the function to match the argument type. This interacts very badly with LLVM and breaks inlining of the glue code. It's more efficient to use a unified function type for the glue functions and always cast the function argument instead of the function. The resulting code for rustc is about 13% faster (measured up to and including the "trans" pass) and the resulting librustc is about 5% smaller.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
May 6, 2021
`Conf` macro improvements part 2 changelog: none Follow-up to rust-lang#7150 I made the default value required again for `define_Conf!` so that it can be parsed by the magic Python. I guess it's just as well for readability. r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when calling glue functions, we cast the function to match
the argument type. This interacts very badly with LLVM and breaks
inlining of the glue code.
It's more efficient to use a unified function type for the glue
functions and always cast the function argument instead of the function.
The resulting code for rustc is about 13% faster (measured up to and
including the "trans" pass) and the resulting librustc is about 5%
smaller.