Skip to content

Turn off const propagation of ref taking #68170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2020
Merged

Turn off const propagation of ref taking #68170

merged 1 commit into from
Jan 18, 2020
+82 −22

Conversation

@wesleywiser
Copy link
Member

@wesleywiser wesleywiser commented Jan 13, 2020

Fixes #67529
Fixes #67640
Fixes #67641
Fixes #67862

r? @oli-obk

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 13, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Jan 13, 2020

@bors r+

@bors
Copy link
Collaborator

bors commented Jan 13, 2020

📌 Commit 7f65475 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 13, 2020
@wesleywiser wesleywiser mentioned this pull request Jan 14, 2020
Closed
bors added a commit that referenced this pull request Jan 14, 2020
@bors
Auto merge of #68213 - wesleywiser:try_turning_on_inliner, r=<try>
dc0f962 
[do not merge] Try turning on MIR inliner by default

Try turning on the MIR inliner by default to measure the performance impact.

Rebased on top of #68170 to get that fix.

r? @ghost
@wesleywiser
Copy link
Member Author

wesleywiser commented Jan 14, 2020

It's possible this could have an impact on performance.

@bors rollup=never

@Aaron1011 Aaron1011 mentioned this pull request Jan 14, 2020
Merged
@bors
Copy link
Collaborator

bors commented Jan 18, 2020

⌛ Testing commit 7f65475 with merge 35b5157...

bors added a commit that referenced this pull request Jan 18, 2020
@bors
Auto merge of #68170 - wesleywiser:stop_const_prop_ref_taking, r=oli-obk
35b5157 
Turn off const propagation of ref taking

Fixes #67529
Fixes #67640
Fixes #67641
Fixes #67862

r? @oli-obk
@bors
Copy link
Collaborator

bors commented Jan 18, 2020

☀️ Test successful - checks-azure
Approved by: oli-obk
Pushing 35b5157 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 18, 2020
@bors bors merged commit 7f65475 into rust-lang:master Jan 18, 2020
@bors bors mentioned this pull request Jan 18, 2020
Closed
@lkurcak lkurcak mentioned this pull request Jun 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@oli-obk oli-obk

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Milestone

No milestone

4 participants

@wesleywiser @oli-obk @bors @rust-highfive