Simplify Clone for Box<[T]> #67312
Simplify Clone for Box<[T]> #67312
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
☔ The latest upstream changes (presumably #67540) made this pull request unmergeable. Please resolve the merge conflicts. |
The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead, let's clone to a real `Vec`, with all of its specialization for the task, then convert back to `Box<[T]>`.
cuviper
force-pushed
the
clone-box-slice
branch
from
06077e7 to
81a6709
Compare
|
Rebased. |
|
r? @SimonSapin |
|
Looks good, thanks! @bors r+ Until something like rust-lang/highfive#241 is added, please consider using https://github.com/rust-lang/highfive/blob/master/highfive/configs/rust-lang/rust.json to find a reviewer. |
|
📌 Commit 81a6709 has been approved by |
bors
added
S-waiting-on-bors
OK, thanks for the link. I knew you were on the libs team and had touched this file relatively recently, but didn't know there was a distinct reviewer list (that you aren't on). Thanks for reviewing anyway! |
Simplify Clone for Box<[T]> The bespoke `BoxBuilder` was basically a very simple `Vec`. Instead, let's clone to a real `Vec`, with all of its specialization for the task, then convert back to `Box<[T]>`.
|
☀️ Test successful - checks-azure |
5 participants
The bespoke
BoxBuilderwas basically a very simpleVec. Instead,let's clone to a real
Vec, with all of its specialization for thetask, then convert back to
Box<[T]>.