Proposal: fold_self and try_fold_self for Iterators
#60103
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
| /// Find the maximum value: | ||
| /// | ||
| /// ``` | ||
| /// fn find_max<I>(iter: I) -> Option<I::Item> |
There was a problem hiding this comment.
Aside from the behavior for Equal, this is just Iterator::max -- maybe a different example can be provided?
| /// ``` | ||
| #[inline] | ||
| #[unstable(feature = "iterator_fold_self", issue = "60103")] | ||
| fn fold_self<F>(mut self, mut f: F) -> Option<Self::Item> |
There was a problem hiding this comment.
For reference, in itertools, this is https://docs.rs/itertools/0.8.0/itertools/trait.Itertools.html#method.fold1 which is inspired by https://hackage.haskell.org/package/base-4.12.0.0/docs/Prelude.html#v:foldl1 in Haskell.
Co-Authored-By: Lucretiel <[email protected]>
scottmcm
added
the
T-libs-api
|
ping from triage @joshtriplett any updates? |
|
Sorry for the delay, I didn't realize my fork wasn't updated with upstream master, and so I believed it when it said I was all up to date after a pull + rebase. There was a pretty substantial refactor of the |
Dylan-DPC-zz
added
S-waiting-on-author
|
ping from triage @Lucretiel any updates? |
|
Closing due to inactivity, but feel free to resubmit with the necessary changes! |
jonas-schievink
added
S-inactive
|
Done! Will re-opening the PR automatically bring in my latest branch changes? |
|
@Lucretiel I think you'll have to open another PR |
7 participants
This pull request proposes & implements two new methods on Iterators:
fold_selfandtry_fold_self. These are variants offoldandtry_foldthat use the first element in the iterator as the initial accumulator.Let me know if a public feature like this requires an RFC, or if this pull request is sufficient as place for discussion.