Move compile-fail tests to ui
#53196
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Member
Author
|
Tests changed in this commit need to be checked as they were failing on NLL compare mode so I just added |
davidtwco
force-pushed
the
compile-fail-to-ui
branch
2 times, most recently
from
5a06915 to
b201be3
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
davidtwco
force-pushed
the
compile-fail-to-ui
branch
from
b201be3 to
b757dfc
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
davidtwco
force-pushed
the
compile-fail-to-ui
branch
from
b757dfc to
4d93fb5
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
davidtwco
force-pushed
the
compile-fail-to-ui
branch
from
4d93fb5 to
ddfd305
Compare
Contributor
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
davidtwco
force-pushed
the
compile-fail-to-ui
branch
from
ddfd305 to
9bfd08b
Compare
Contributor
|
@bors r+ |
Collaborator
|
📋 Looks like this PR is still in progress, ignoring approval. Hint: Remove WIP from this PR's title when it is ready for review. |
Contributor
|
@bors p=1 -- conflict prone |
nikomatsakis
changed the title
compile-fail tests to ui compile-fail tests to ui
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit 9bfd08b434aa10cdcc4188daf03dc9743607cfd8 has been approved by |
bors
added
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 9bfd08b434aa10cdcc4188daf03dc9743607cfd8 with merge edac511dd0c259e819661a112dc6aebc63221570... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
kennytm
added
S-waiting-on-author
davidtwco
force-pushed
the
compile-fail-to-ui
branch
2 times, most recently
from
6d97f2b to
82c1a0f
Compare
davidtwco
force-pushed
the
compile-fail-to-ui
branch
from
305a428 to
7b02656
Compare
Contributor
|
@bors r=nikomatsakis |
Collaborator
|
📌 Commit 7b02656 has been approved by |
bors
added
S-waiting-on-bors
Contributor
|
@bors p=2 |
Collaborator
bors
added a commit
that referenced
this pull request
Aug 14, 2018
Move `compile-fail` tests to `ui` Fixes #46841, #52531, #44844. r? @nikomatsakis
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Aug 14, 2018
pnkfelix
added a commit
to pnkfelix/rust
that referenced
this pull request
Aug 14, 2018
… from rust-lang#53196. See also the bulletpoint list on rust-lang#53351.
This was referenced Aug 15, 2018
This was referenced Sep 24, 2018
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Oct 28, 2018
This script broke after rust-lang#53196 after the tests were moved.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Oct 29, 2018
…mulacrum Fix invalid path in generate-deriving-span-tests.py. This script broke after rust-lang#53196 – the tests were moved.
Contributor
|
If you (like me) are trying to trace through the history and want to get to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46841, #52531, #44844.
r? @nikomatsakis