proc_macro: Explicitly make everything !Send/Sync #50453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds explicit imp blocks to ensure that all publicly exported types (except simple enums) are not `Send` nor `Sync` in the `proc_macro` crate. cc rust-lang#38356
Member
Author
31 tasks
Member
|
@bors r+ |
Collaborator
|
📌 Commit 3e0ed2f has been approved by |
bors
added
the
S-waiting-on-bors
Collaborator
|
⌛ Testing commit 3e0ed2f with merge df07f3d2114836dec175ebf6b5987d9416ed2de8... |
Collaborator
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
Member
Author
|
@bors: retry I sure hope this didn't cause rustc to segfault.. |
bors
added
S-waiting-on-bors
Collaborator
bors
added a commit
that referenced
this pull request
May 6, 2018
proc_macro: Explicitly make everything !Send/Sync This commit adds explicit imp blocks to ensure that all publicly exported types (except simple enums) are not `Send` nor `Sync` in the `proc_macro` crate. cc #38356
Collaborator
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds explicit imp blocks to ensure that all publicly exported types
(except simple enums) are not
SendnorSyncin theproc_macrocrate.cc #38356