Add debug info tests #4862
Closed
Add debug info tests #4862
+158
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Contributor
|
@catamorphism That's a good point, and no I don't think so. I think turning debug info tests off if configure doesn't find gdb would be appropriate. We could also turn the gdb tests off by default (like the perf tests) and just configure the bots to run them, but i prefer the former. I am going to take a stab at that - I want to try to put a big warning on the test output that some tests weren't run - but I'm going to r+ this anyway to see how the bots feel about gdb. |
Contributor
|
Oh, it looks like this doesn't make the debuginfo tests run by default, so I think we're ok as far as the gdb dependency. You would have to type |
Closed
Contributor
|
I opened #4876 with that typo fix and the change to run the tests conditionally |
bors
added a commit
that referenced
this pull request
Feb 12, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2195.
The testing procedure mimics the way clang/llvm does their debuginfo tests - it creates a debugging commands script from directives in the header file which gdb runs in batch mode with the executable, and then checks if output is as expected. I have two very simple tests included, and they're both ignored because rust doesn't seem to emit good enough symbols for them to pass (by the way, I'll see if I can help fix that).
Note that once debug info tests are enabled, gdb will become a dependency for 'make check'.
(This replaces a pull request based on an earlier commit.)