Skip to content

Conversation

@MajorBreakfast
Copy link
Contributor

@MajorBreakfast MajorBreakfast commented Feb 26, 2017

Sounds better with present perfect because there's a link to the present.

I'm not a native speaker, though. So, plz check whether it really is better ;)

r? @steveklabnik

@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Contributor

Seems fine to me either way. Thanks!

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 26, 2017

📌 Commit 912ce53 has been approved by steveklabnik

@bors
Copy link
Collaborator

bors commented Feb 27, 2017

⌛ Testing commit 912ce53 with merge cb1f649...

bors added a commit that referenced this pull request Feb 27, 2017
Loop docs: Present perfect instead of simple past

Sounds better with present perfect because there's a link to the present.

I'm not a native speaker, though. So, plz check whether it really is better ;)

r? @steveklabnik
@bors
Copy link
Collaborator

bors commented Feb 27, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: steveklabnik
Pushing cb1f649 to master...

@bors bors merged commit 912ce53 into rust-lang:master Feb 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants