rustbuild: Fix copy helper with existing files
#38405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This erroneously truncated files when the destination already existed and was an existing hard link to the source. This in turn caused weird bugs! Closes rust-lang#37745
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@bors r+ |
Collaborator
|
📌 Commit a519305 has been approved by |
Collaborator
|
⌛ Testing commit a519305 with merge cdeb33e... |
Collaborator
|
💔 Test failed - auto-win-msvc-64-cargotest |
Member
Author
|
@bors: retry
…On Fri, Dec 16, 2016 at 7:11 AM, bors ***@***.***> wrote:
💔 Test failed - auto-win-msvc-64-cargotest
<https://buildbot.rust-lang.org/builders/auto-win-msvc-64-cargotest/builds/2618>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#38405 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95Eg9Q8lQCmwW8MhWaL6WBAHSL5M8ks5rIqo9gaJpZM4LO0t4>
.
|
Contributor
|
@bors retry |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 19, 2016
rustbuild: Fix `copy` helper with existing files This erroneously truncated files when the destination already existed and was an existing hard link to the source. This in turn caused weird bugs! Closes #37745
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This erroneously truncated files when the destination already existed and was an
existing hard link to the source. This in turn caused weird bugs!
Closes #37745