Forward more ExactSizeIterator methods and is_empty edits
#38149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
Huh, I don't understand this travis error, which shows up in tidy after it already built the regular build successfully. error: unused or unknown feature
--> /checkout/src/liballoc/lib.rs:82:12
|
82 | #![feature(exact_size_is_empty)]
| ^^^^^^^^^^^^^^^^^^^
| |
Improve is_empty on the VecDeque and its iterators by just comparing tail and head; this saves a few instructions (to be able to remove the `& (size - 1)` computation, it would have to know that size is a power of two).
Contributor
Author
|
I've tried to address the tidy failure by making the exact_size_is_empty feature conditional; it's unused when |
Member
|
@bors: r+ Thanks! |
Collaborator
|
📌 Commit d53f82c has been approved by |
Collaborator
bors
added a commit
that referenced
this pull request
Dec 7, 2016
Forward more ExactSizeIterator methods and `is_empty` edits - Forward ExactSizeIterator methods in more places, like `&mut I` and `Box<I>` iterator impls. - Improve `VecDeque::is_empty` itself (see commit 4) - All the collections iterators now have `len` or `is_empty` forwarded if doing so is a benefit. In the remaining cases, they already use a simple size hint (using something like a stored `usize` value), which is sufficient for the default implementation of len and is_empty.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
&mut IandBox<I>iterator impls.VecDeque::is_emptyitself (see commit 4)lenoris_emptyforwarded if doing so is a benefit. In the remaining cases, they already use a simple size hint (using something like a storedusizevalue), which is sufficient for the default implementation of len and is_empty.