Skip to content

Stabilize RFC 1560 #37127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 21, 2016
Merged

Stabilize RFC 1560 #37127

merged 3 commits into from
Nov 21, 2016

Conversation

@jseyfried
Copy link
Contributor

@jseyfried jseyfried commented Oct 12, 2016 •
edited
Loading

Fixes #13598, fixes #23157, fixes #32303.
cc #35120
r? @nrc

@nrc
Copy link
Member

nrc commented Oct 12, 2016

We don't want to land this until the end of the cycle, right?

@nikomatsakis or someone else, can you start a Crater run with this please?

@jseyfried
Copy link
Contributor Author

jseyfried commented Oct 12, 2016

We don't want to land this until the end of the cycle, right?

Right -- I think the implementation is ready to be stabilized now but there's little harm in waiting.

@bluss bluss added relnotes Marks issues that should be documented in the release notes of the next release. S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Oct 12, 2016
@bors
Copy link
Collaborator

bors commented Oct 13, 2016

☔ The latest upstream changes (presumably #37118) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried jseyfried force-pushed the stabilize_RFC_1560 branch 3 times, most recently from f8bba59 to dab9dd4 Compare October 13, 2016 10:01
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Oct 17, 2016

Started crater run from commit d34318d to dab9dd47a4504b068ee336ca4b809cc19380b680. Sorry for delay.

@bors
Copy link
Collaborator

bors commented Oct 19, 2016

☔ The latest upstream changes (presumably #37269) made this pull request unmergeable. Please resolve the merge conflicts.

@bluss bluss removed the S-waiting-on-crater Status: Waiting on a crater run to be completed. label Oct 19, 2016
@nikomatsakis
Copy link
Contributor

nikomatsakis commented Oct 24, 2016 •
edited
Loading

Crater run results (not analyzed)

Root regressions, sorted by rank:

@bluss
Copy link
Contributor

bluss commented Oct 24, 2016 •
edited
Loading

  • borealis → unlucky timing and got a now-yanked version of its dep html5ever, causing the error. So it's not a regression.
  • climatempo → same as borealis

The rest are timeouts. No regressions!

@bors
Copy link
Collaborator

bors commented Oct 27, 2016

☔ The latest upstream changes (presumably #36695) made this pull request unmergeable. Please resolve the merge conflicts.

@petrochenkov petrochenkov mentioned this pull request Oct 27, 2016
Closed
@alexcrichton
Copy link
Member

alexcrichton commented Nov 10, 2016

The cycle ended recently, and with no regressions on crater, is this good to go? @jseyfried want to rebase and @nrc want to r+?

@jseyfried jseyfried force-pushed the stabilize_RFC_1560 branch 2 times, most recently from de42e12 to 2459bd2 Compare November 10, 2016 21:46
@nrc
Copy link
Member

nrc commented Nov 11, 2016

r = me

@brson
Copy link
Contributor

brson commented Nov 11, 2016

@bors r=nrc

@bors
Copy link
Collaborator

bors commented Nov 11, 2016

📌 Commit 9785ec9 has been approved by nrc

@jseyfried jseyfried force-pushed the stabilize_RFC_1560 branch 2 times, most recently from e2365df to 76b9fdf Compare November 11, 2016 07:43
@bors
Copy link
Collaborator

bors commented Nov 17, 2016

☔ The latest upstream changes (presumably #37732) made this pull request unmergeable. Please resolve the merge conflicts.

@jseyfried
Copy link
Contributor Author

jseyfried commented Nov 21, 2016

@bors r=nrc

@bors
Copy link
Collaborator

bors commented Nov 21, 2016

📌 Commit 649bcd4 has been approved by nrc

@bors
Copy link
Collaborator

bors commented Nov 21, 2016

⌛ Testing commit 649bcd4 with merge 59b87b3...

bors added a commit that referenced this pull request Nov 21, 2016
@bors
Auto merge of #37127 - jseyfried:stabilize_RFC_1560, r=nrc
59b87b3 
Stabilize RFC 1560

Fixes #13598, fixes #23157, fixes #32303.
cc #35120
r? @nrc
@bors
Copy link
Collaborator

bors commented Nov 21, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: nrc
Pushing 59b87b3 to master...

@bors bors merged commit 649bcd4 into rust-lang:master Nov 21, 2016
@bors bors mentioned this pull request Nov 21, 2016
Merged
@jseyfried jseyfried mentioned this pull request Nov 26, 2016
Closed
@jseyfried jseyfried mentioned this pull request Dec 6, 2016
Closed
@jseyfried jseyfried deleted the stabilize_RFC_1560 branch December 8, 2016 07:50
This was referenced Dec 26, 2016
Closed
Closed
@jseyfried jseyfried mentioned this pull request Jan 21, 2017
Closed
@rpjohnst rpjohnst mentioned this pull request Sep 7, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nrc nrc

Labels

relnotes Marks issues that should be documented in the release notes of the next release.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Importing private reexports does not work glob imports ignore private items use self::b has stopped consulting local non-pub use of b

7 participants

@jseyfried @nrc @bors @nikomatsakis @bluss @alexcrichton @brson