Skip to content

Improve Path and PathBuf docs #35786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2016
Merged

Improve Path and PathBuf docs #35786

merged 1 commit into from
Sep 1, 2016

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Aug 18, 2016

@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 18, 2016

Thanks! 😄

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 18, 2016

📌 Commit d56f9ff has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 18, 2016
@steveklabnik
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
089b84d 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Aug 18, 2016
Closed
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 19, 2016

Updated.

@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 19, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 19, 2016

📌 Commit 481b0f3 has been approved by steveklabnik

@sophiajt
Copy link
Contributor

sophiajt commented Aug 19, 2016

@bors r-

From the best I can tell, this seems to fail bors. https://buildbot.rust-lang.org/builders/auto-mac-64-opt/builds/10236/steps/test/logs/stdio

@GuillaumeGomez - can you confirm that this works on the latest Rust? Some new error message went in recently that may have changed things.

@sophiajt
Copy link
Contributor

sophiajt commented Aug 19, 2016

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 19, 2016

📌 Commit 481b0f3 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 20, 2016
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=jonatha…
1522780 
…ndturner

Improve Path and PathBuf docs

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Aug 20, 2016
Closed
eddyb added a commit to eddyb/rust that referenced this pull request Aug 22, 2016
@eddyb
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=jonatha…
b710efb 
…ndturner

Improve Path and PathBuf docs

r? @steveklabnik
@eddyb eddyb mentioned this pull request Aug 22, 2016
Closed
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 22, 2016
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=jonatha…
e6ab353 
…ndturner

Improve Path and PathBuf docs

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Aug 22, 2016
Closed
@sophiajt
Copy link
Contributor

sophiajt commented Aug 22, 2016

@bors r-

Looks like this might have some broken links on OS X. This is from the latest rollup:

Linkcheck stage2 (x86_64-apple-darwin)
core/result/index.html:392: broken link - core/result/struct.Result.html
core/result/struct.IntoIter.html:54: broken link - core/result/struct.Result.html
std/path/struct.Path.html:474: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.Path.html:496: broken link - std/path/fmt/trait.Display.html
std/path/struct.PathBuf.html:598: broken link - std/path/ffi/struct.OsStr.html
std/path/struct.PathBuf.html:620: broken link - std/path/fmt/trait.Display.html
std/result/index.html:392: broken link - std/result/struct.Result.html
std/result/struct.IntoIter.html:54: broken link - std/result/struct.Result.html

@sophiajt sophiajt mentioned this pull request Aug 22, 2016
Merged
@frewsxcv frewsxcv mentioned this pull request Aug 23, 2016
Closed
@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 25, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 25, 2016

📌 Commit a377adb has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 25, 2016
@steveklabnik
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
97b7813 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Aug 25, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
@steveklabnik
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
2fccdbd 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Aug 26, 2016
Closed
steveklabnik added a commit to steveklabnik/rust that referenced this pull request Aug 26, 2016
@steveklabnik
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
bfeb433 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@steveklabnik steveklabnik mentioned this pull request Aug 26, 2016
Closed
Manishearth added a commit to Manishearth/rust that referenced this pull request Aug 27, 2016
@Manishearth
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
d16fb03 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@Manishearth Manishearth mentioned this pull request Aug 27, 2016
Closed
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 29, 2016

@bors: r-

Still link failure.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Aug 31, 2016

Updated links and checked manually after

make docs

All good now.

@steveklabnik
Copy link
Contributor

steveklabnik commented Aug 31, 2016

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 31, 2016

📌 Commit 96e3103 has been approved by steveklabnik

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
Rollup merge of rust-lang#35786 - GuillaumeGomez:paths_doc, r=stevekl…
4bc5bcd 
…abnik

Improve Path and PathBuf docs

r? @steveklabnik
@sophiajt sophiajt mentioned this pull request Aug 31, 2016
Merged
bors added a commit that referenced this pull request Sep 1, 2016
@bors
Auto merge of #36177 - jonathandturner:rollup, r=jonathandturner
3135b78 
Rollup of 13 pull requests

- Successful merges: #35773, #35786, #35911, #35927, #36083, #36087, #36098, #36114, #36118, #36123, #36129, #36152, #36169
- Failed merges:
@bors bors merged commit 96e3103 into rust-lang:master Sep 1, 2016
@GuillaumeGomez GuillaumeGomez deleted the paths_doc branch September 1, 2016 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@GuillaumeGomez @steveklabnik @bors @sophiajt