Skip to content

Make vec::view a method too. #3526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 27, 2012
Merged

Make vec::view a method too. #3526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/libcore/vec.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1625,6 +1625,7 @@ impl<T: Copy> &[const T]: CopyableVector<T> {
}

trait ImmutableVector<T> {
pure fn view(start: uint, end: uint) -> &[T];
pure fn foldr<U: Copy>(z: U, p: fn(T, U) -> U) -> U;
pure fn iter(f: fn(T));
pure fn iteri(f: fn(uint, T));
Expand All @@ -1647,6 +1648,10 @@ trait ImmutableEqVector<T: Eq> {

/// Extension methods for vectors
impl<T> &[T]: ImmutableVector<T> {
/// Return a slice that points into another slice.
pure fn view(start: uint, end: uint) -> &[T] {
view(self, start, end)
}
/// Reduce a vector from right to left
#[inline]
pure fn foldr<U: Copy>(z: U, p: fn(T, U) -> U) -> U { foldr(self, z, p) }
Expand Down Expand Up @@ -2909,17 +2914,14 @@ mod tests {
assert capacity(v) == 10u;
}

/*
#[test]
#[ignore] // region inference doesn't work well enough for this yet.
fn test_view() {
let v = ~[1, 2, 3, 4, 5];
let v = view(v, 1u, 3u);
let v = v.view(1u, 3u);
assert(len(v) == 2u);
assert(v[0] == 2);
assert(v[1] == 3);
}
*/
}

// Local Variables:
Expand Down