Skip to content

Improve DoubleEndedIterator examples #34688

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2016
Merged

Improve DoubleEndedIterator examples #34688

merged 1 commit into from
Jul 8, 2016

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jul 6, 2016

Fixes #34065.

r? @steveklabnik

@steveklabnik
Copy link
Contributor

steveklabnik commented Jul 6, 2016

@GuillaumeGomez the original author hasn't yet weighed in; I'm not sure why this is significantly better.

@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Jul 7, 2016

@steveklabnik: The original example only shows one call. By increasing the size of the array, it appears more accurately what next_back is doing.

@steveklabnik
Copy link
Contributor

steveklabnik commented Jul 7, 2016

Ah, okay.

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Jul 7, 2016

📌 Commit 630e4eb has been approved by steveklabnik

Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2016
@Manishearth
Rollup merge of rust-lang#34688 - GuillaumeGomez:double_ended_iterato…
55993ac 
…r, r=steveklabnik

Improve DoubleEndedIterator examples

Fixes rust-lang#34065.

r? @steveklabnik
@Manishearth Manishearth mentioned this pull request Jul 8, 2016
Merged
bors added a commit that referenced this pull request Jul 8, 2016
@bors
Auto merge of #34720 - Manishearth:rollup, r=Manishearth
d8a65cd 
Rollup of 9 pull requests

- Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700
- Failed merges:
Manishearth added a commit to Manishearth/rust that referenced this pull request Jul 8, 2016
@Manishearth
Rollup merge of rust-lang#34688 - GuillaumeGomez:double_ended_iterato…
4ee6a66 
…r, r=steveklabnik

Improve DoubleEndedIterator examples

Fixes rust-lang#34065.

r? @steveklabnik
bors added a commit that referenced this pull request Jul 8, 2016
@bors
Auto merge of #34720 - Manishearth:rollup, r=Manishearth
e7751e4 
Rollup of 9 pull requests

- Successful merges: #34097, #34456, #34610, #34612, #34659, #34688, #34691, #34699, #34700
- Failed merges:
@bors bors merged commit 630e4eb into rust-lang:master Jul 8, 2016
@GuillaumeGomez GuillaumeGomez deleted the double_ended_iterator branch July 9, 2016 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@steveklabnik steveklabnik

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GuillaumeGomez @steveklabnik @bors