collections: Add slice::binary_search_by_key #32693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
kamalmarhubi
force-pushed
the
binary_search_by_key
branch
from
723f9d3 to
a13540b
Compare
alexcrichton
added
the
T-libs-api
Collaborator
|
☔ The latest upstream changes (presumably #32804) made this pull request unmergeable. Please resolve the merge conflicts. |
This method adds to the family of `_by_key` methods, and is the counterpart of `slice::sort_by_key`. It was mentioned on rust-lang#30423 but was not implemented at that time. Refs rust-lang#30423
kamalmarhubi
force-pushed
the
binary_search_by_key
branch
from
a13540b to
62945b6
Compare
Contributor
Author
|
Rebased. |
Member
|
The libs team discussed this during triage yesterday and the conclusion was to merge, thanks again for the PR @kamalmarhubi! |
Collaborator
Contributor
Author
|
@alexcrichton Does it need a tracking issue to be filled in? |
Member
|
Guh right, yes! If this lands, wanna file a follow-up PR filling that in? Also feel free to open the issue, I'll fill out the tags |
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method adds to the family of
_by_keymethods, and is thecounterpart of
slice::sort_by_key. It was mentioned on #30423 butwas not implemented at that time.
Refs #30423