docs for Reflect: blank line after first sentence #29593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
|
@bors: r+ rollup |
Collaborator
|
📌 Commit d7a3260 has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Nov 5, 2015
…veklabnik Rustdoc takes the first paragraph as a summary, so having a huge paragraph that ends with introducing an example looked somewhat wrong on the module page.
Contributor
|
This failed the rollup because there's trailing whitespace, can you make sure to trim it, please? |
Contributor
|
@bors: r- |
Rustdoc takes the first paragraph as a summary, so having a huge paragraph that ends with introducing an example looked somewhat wrong on the module page.
ben0x539
force-pushed
the
reflect-doc-comment
branch
from
d7a3260 to
4db95e6
Compare
Contributor
Author
|
Whoops. Updated with "/// " -> "///". |
Contributor
|
@bors: r+ rollup no worries, I do that all the time |
Collaborator
|
📌 Commit 4db95e6 has been approved by |
Collaborator
|
⌛ Testing commit 4db95e6 with merge 74185af... |
bors
added a commit
that referenced
this pull request
Nov 5, 2015
Rustdoc takes the first paragraph as a summary, so having a huge paragraph that ends with introducing an example looked somewhat wrong on the module page.
Collaborator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rustdoc takes the first paragraph as a summary, so having a huge
paragraph that ends with introducing an example looked somewhat wrong on
the module page.