Rollup of 5 pull requests #29569
Closed
Rollup of 5 pull requests #29569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
steveklabnik
commented
Nov 4, 2015
steveklabnik
commented
- Successful merges: run rustfmt on std::path #29200, Specify Microsoft Windows and Mac OS X explicitly #29528, Closes #24954 #29537, Mention what iterator terminators do with an empty iterator #29539, Fix #29542 #29567
- Failed merges:
There was a bunch of manual fixes too... rustfmt isn't quite there yet
When referring to the different shared library extensions, specify the OS explicitly.
Reword "Writing the logic" paragraph to prevent `unwrap` being confused for a macro.
…s-minor, r=nikomatsakis When referring to the different shared library extensions, specify the OS explicitly.
Reword "Writing the logic" paragraph to prevent `unwrap` being confused for a macro (and other small changes to improve the flow of the paragraph). cc @steveklabnik
Contributor
Author
|
@bors: r+ p=1 |
Contributor
|
(rust_highfive has picked a reviewer for you, use r? to override) |
Contributor
Author
|
@bors: r+ p=1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.