Skip to content

Make stability attributes an error. #22830 #24646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2015
Merged

Make stability attributes an error. #22830 #24646

merged 1 commit into from
Apr 21, 2015

Conversation

@brson
Copy link
Contributor

@brson brson commented Apr 21, 2015

No description provided.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 21, 2015
@rust-highfive
Copy link
Contributor

rust-highfive commented Apr 21, 2015

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

sfackler
sfackler reviewed Apr 21, 2015
View reviewed changes
src/test/compile-fail/stability-attribute-non-staged.rs Outdated
Copy link
Member

@sfackler sfackler Apr 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING should be ERROR here, right?

Copy link
Contributor Author

@brson brson Apr 21, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.

@alexcrichton
Copy link
Member

alexcrichton commented Apr 21, 2015

@bors: r+ bb407b1 p=1

@bors
Copy link
Collaborator

bors commented Apr 21, 2015

⌛ Testing commit bb407b1 with merge 3860240...

bors added a commit that referenced this pull request Apr 21, 2015
@bors
Auto merge of #24646 - brson:stab, r=alexcrichton
3860240
@bors
Copy link
Collaborator

bors commented Apr 21, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit bb407b1 into rust-lang:master Apr 21, 2015
@alexcrichton alexcrichton mentioned this pull request Apr 23, 2015
Merged
@brson
Copy link
Contributor Author

brson commented Apr 23, 2015

(breaking change)

@pnkfelix
Copy link
Contributor

pnkfelix commented Apr 23, 2015

going from nominated to (nominated, accepted), asap.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 23, 2015
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alexcrichton alexcrichton

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@brson @rust-highfive @alexcrichton @bors @pnkfelix @sfackler