Skip to content

book: 'x' is already taken, so use something else #23746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

book: 'x' is already taken, so use something else #23746

wants to merge 1 commit into from

Conversation

@tshepang
Copy link
Member

@tshepang tshepang commented Mar 26, 2015

This caused me some confusion

@rust-highfive
Copy link
Contributor

rust-highfive commented Mar 26, 2015

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson
Copy link
Contributor

brson commented Mar 26, 2015

Can you expand on what's confusing about 'x' here? This is the first example of the chapter and 'x' wasn't mentioned previously.

@tshepang
Copy link
Member Author

tshepang commented Mar 26, 2015

It's used in the first 2 code blocks in the page, and that's a differernt x to those in the other code blocks.

@steveklabnik
Copy link
Contributor

steveklabnik commented Mar 26, 2015

qux, while one of the more interesting metasyntactic variables, is also likely to be confusing, as it's less often used. Maybe just a bar?

@tshepang
Copy link
Member Author

tshepang commented Mar 26, 2015

@steveklabnik done

@brson
Copy link
Contributor

brson commented Mar 27, 2015

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 27, 2015

📌 Commit 7447c05 has been approved by brson

@bors
Copy link
Collaborator

bors commented Mar 28, 2015

☔ The latest upstream changes (presumably #23796) made this pull request unmergeable. Please resolve the merge conflicts.

@bors
Copy link
Collaborator

bors commented Mar 28, 2015

🔒 Merge conflict

@Manishearth
Copy link
Member

Manishearth commented Mar 30, 2015

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 30, 2015

📌 Commit 435da68 has been approved by Manishearth

@Manishearth Manishearth mentioned this pull request Mar 30, 2015
Merged
bors added a commit that referenced this pull request Mar 30, 2015
@bors
Auto merge of #23861 - Manishearth:rollup, r=Manishearth
6cf3b0b 
- Successful merges: #23746, #23836, #23852
- Failed merges: #23855
@bors
Copy link
Collaborator

bors commented Mar 30, 2015

☔ The latest upstream changes (presumably #23861) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth
Copy link
Member

Manishearth commented Mar 30, 2015

Merged in 6cf3b0b

@emberian emberian closed this Mar 30, 2015
@tshepang tshepang deleted the doc-avoid-x-confusion branch March 30, 2015 20:44
@tshepang
Copy link
Member Author

tshepang commented Apr 10, 2015

Looks like this wasn't actually merged. I was made aware of this by http://internals.rust-lang.org/t/newcomer-to-rust-my-experience/1816/52?u=tshepang.

@tshepang tshepang restored the doc-avoid-x-confusion branch April 10, 2015 22:36
@tshepang
Copy link
Member Author

tshepang commented Apr 10, 2015

@cmr re-submitted as #24309

@Manishearth
Copy link
Member

Manishearth commented Apr 11, 2015

Oh, oops. My bad, sorry.

@tshepang
Copy link
Member Author

tshepang commented Apr 11, 2015

is kool my man, is kool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@brson brson

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@tshepang @rust-highfive @brson @steveklabnik @bors @Manishearth @emberian