-
Notifications
You must be signed in to change notification settings - Fork 14k
Revert stability for Bitv and BitvSet #21208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I'm not great at how the stability attributes work, but I believe it's fine to stabilize the methods, just not the type itself. Basically stating that "I dunno if we're gonna have this type, but if we do, it'll look like this". |
|
r? @aturon |
Yes, exactly. This PR should revert only the types and modules. |
|
Will do tomorrow. |
d206f93 to
0fda5b2
Compare
The collections were promoted to stable by mistake and do not match RFC 509. This reverts the stability back to unstable. [breaking-change] since previously stable API became unstable. Fixes rust-lang#21193
|
Only |
|
@nagisa Thanks! But would you mind also reverting the modules |
0fda5b2 to
bc03bf8
Compare
|
Ah, must have forgoten to push that, done. |
Revert stability for Bitv and BitvSet Reviewed-by: aturon, aturon
Revert stability for Bitv and BitvSet Reviewed-by: aturon, aturon
|
Doing this manually as part of #21300 |
The collections were promoted to stable by mistake and do not match RFC 509.
This reverts the stability back to unstable.
[breaking-change] since previously stable API became unstable.
Fixes #21193
r? @gankro