Skip to content

Register new snapshots #16859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 30, 2014
Merged

Register new snapshots #16859

merged 1 commit into from
Aug 30, 2014

Conversation

@alexcrichton
Copy link
Member

@alexcrichton alexcrichton commented Aug 29, 2014

No description provided.

@eddyb
Copy link
Member

eddyb commented Aug 29, 2014

I wonder if the issue_5723_bootstrap feature can be marked as "accepted" or removed.
cc @nikomatsakis

@huonw
Copy link
Contributor

huonw commented Aug 30, 2014

@eddyb

rust/src/librustc/front/feature_gate.rs

Line 77 in 5419b2c

("issue_5723_bootstrap", Accepted),

@nikomatsakis
Copy link
Contributor

nikomatsakis commented Aug 30, 2014

@eddyb as @huonw said I already marked it as accepted, but arguably it could just be removed entirely, though technically that violates feature-gate protocol. I doubt anyone in "the wild" is using it.

@eddyb eddyb mentioned this pull request Aug 30, 2014
Merged
bors added a commit that referenced this pull request Aug 30, 2014
@bors
auto merge of #16859 : alexcrichton/rust/snapshots, r=huonw
f297366
@bors bors closed this Aug 30, 2014
@bors bors merged commit d15d559 into rust-lang:master Aug 30, 2014
@alexcrichton alexcrichton deleted the snapshots branch September 10, 2014 17:35
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 7, 2024
@bors
Auto merge of rust-lang#16924 - poliorcetics:ab/push-kxwqvtypvlsq, r=…
80131ce 
…Veykril

feat: Add `rust-analyzer.cargo.allTargets` to configure passing `--all-targets` to cargo invocations

Closes rust-lang#16859

## Unresolved question:

Should this be a setting for build scripts only ? All the other `--all-targets` I found where already covered by `checkOnSave.allTargets`
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
@bors
Auto merge of rust-lang#16924 - poliorcetics:ab/push-kxwqvtypvlsq, r=…
2678660 
…Veykril

feat: Add `rust-analyzer.cargo.allTargets` to configure passing `--all-targets` to cargo invocations

Closes rust-lang#16859

## Unresolved question:

Should this be a setting for build scripts only ? All the other `--all-targets` I found where already covered by `checkOnSave.allTargets`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@alexcrichton @eddyb @huonw @nikomatsakis @bors