Support Rust tab conventions in vim #15416
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
Contributor
|
yes pls |
Contributor
|
This belongs in the ftplugin, not the ftdetect We also already have an indent file that sets |
Contributor
|
I've submitted the correct implementation (in ftplugin) as #15429. |
Contributor
|
#15429 has been merged and makes this patch obsolete. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Aug 21, 2023
Display fully qualified associated types correctly Currently they are formatted in the internal `Trait<Self = Type>::Assoc` forms where `hir_ty::TypeRef` is formatted, like hover. There is no test of `TypeRef::hir_fmt` in crate `hir-ty` (verified by replacing it with a `panic!()`), most tests are about inference and printing the real `Ty` instead of `TypeRef`. So I added the test in `ide::hover`.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Aug 7, 2025
…estion (rust-lang#15416) The `unnecessary_sort_by` lint displays different method names in message and suggestion, which is a bit confusing. Also got a question about `UNNECESSARY_SORT_BY` lint definition. Should we extend its message to also cover *_unstable_* methods? changelog: [`unnecessary-sort-by`]: sort method consistency in message and suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.