-
Notifications
You must be signed in to change notification settings - Fork 14k
Use yarn instead of npm for JS/TS dependencies
#148763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
yarn instead of npm for JS/TS dependencies
|
This PR modifies If appropriate, please update This PR modifies If appropriate, please update Some changes occurred in HTML/CSS/JS. |
|
r? @clubby789 rustbot has assigned @clubby789. Use |
|
r? @Kobzol since you're already kinda familiar with the situation? (maybe also @notriddle for the small TS fixes, if you can take a look) |
|
|
|
☔ The latest upstream changes (presumably #148885) made this pull request unmergeable. Please resolve the merge conflicts. |
This comment has been minimized.
This comment has been minimized.
|
Since we install |
|
Trying to create rollups, this seems likely to conflict. Bumping priority @bors p=1 rollup=iffy |
|
Actually, I see it already has conflicts, so it needs a rebase. @bors r- |
This comment has been minimized.
This comment has been minimized.
…rors that started popping when we moved to `yarn` Updating `es-check` managed to solve a problem about a missing type file for `minimatch` which I couldn't get around any other way
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing cc328c1 (parent) -> 66bc5a4 (this PR) Test differencesShow 2 test diffs2 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 66bc5a43e55eae14a2ec70b11004c88072fe7f02 --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (66bc5a4): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 2.0%, secondary -0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 474.713s -> 473.832s (-0.19%) |
Building on @lolbinarycat 's excellent work ( #148672 ).
npmapparently has certain edge-cases where it doesn't actually respect the lockfile it's fed, which has led to at least one CI breakage.yarnseems to not suffer from those same issues, and also has a--frozenflag for itsinstallcommand