Remove #[const_trait]
#148683
Merged
Remove #[const_trait]
#148683
+931
−1,070
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmease
added
F-const_trait_impl
Collaborator
|
Some changes occurred to the CTFE machinery Some changes occurred in compiler/rustc_attr_parsing Some changes occurred in compiler/rustc_hir/src/attrs Some changes occurred to constck cc @fee1-dead Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
rustbot
added
A-attributes
fmease
commented
Nov 8, 2025
| //[nyy,nyn,nny,nnn]~^ ERROR: const trait impls are experimental | ||
| #[cfg(any(yny, ynn, nny, nnn))] trait Foo { fn a(&self); } | ||
|
|
||
| #[cfg_attr(any(yyy, yny, nyy, nyn), const_trait)] |
Member
Author
There was a problem hiding this comment.
The nyn was incorrect in that it didn't follow the pattern that's explicitly established at the top of the file (where 0 |-> const_trait_impl enabled?, 1 |-> Foo const?, 2 |-> Bar const?) since the last n incorrectly claimed that under this revision Bar was not const despite literally enabling #[const_trait] when active.
Replaced with nny, hence some of the error annotation changes.
fmease
commented
Nov 8, 2025
| && let &TraitOrTraitImpl::Trait { vis, constness: ast::Const::No } = parent | ||
| { | ||
| Some(span.shrink_to_lo()) | ||
| Some(map.span_extend_while_whitespace(vis).shrink_to_hi()) |
Member
Author
There was a problem hiding this comment.
This pattern occurs in three more places (tho you can't really abstract over it). It yields a syntactically correct suggestion with any(*) combination of trait modifiers/qualifiers present and can deal with inherited visibility, pub , pub(…) and pub(…) (i.e., no trailing space).
(*): It does not account for specialization's default which theoretically comes before const (like visibility), however that's actually syntactically invalid but the parser does recover from it. Still, it's really not worth accounting for.
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
rm-const_trait-attr
branch
from
1009c65 to
c262920
Compare
Member
|
Thanks! @bors r+ |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 9, 2025
…-dead Remove `#[const_trait]` Remove `#[const_trait]` since we now have `const trait`. Update all structured diagnostics that still suggested the attribute. r? `@rust-lang/project-const-traits`
bors
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup of 10 pull requests Successful merges: - #148608 (Add test for --test-builder success path) - #148683 (Remove `#[const_trait]`) - #148687 (std: use a non-poisoning `RwLock` for the panic hook) - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - #148716 (mgca: Finish implementation of `#[type_const]`) - #148722 (Add Crystal Durham to .mailmap) - #148723 (bootstrap: Render doctest timing reports as text, not JSON) - #148724 (tidy: Don't bypass stderr output capture in unit tests) - #148734 (miri subtree update) - #148736 (Fix typo in unstable-book link) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 9, 2025
…-dead Remove `#[const_trait]` Remove `#[const_trait]` since we now have `const trait`. Update all structured diagnostics that still suggested the attribute. r? ``@rust-lang/project-const-traits``
bors
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup of 10 pull requests Successful merges: - #148683 (Remove `#[const_trait]`) - #148687 (std: use a non-poisoning `RwLock` for the panic hook) - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - #148716 (mgca: Finish implementation of `#[type_const]`) - #148722 (Add Crystal Durham to .mailmap) - #148723 (bootstrap: Render doctest timing reports as text, not JSON) - #148724 (tidy: Don't bypass stderr output capture in unit tests) - #148734 (miri subtree update) - #148736 (Fix typo in unstable-book link) - #148744 (Add myself(chenyukang) to the review rotation) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 9, 2025
Rollup merge of #148683 - fmease:rm-const_trait-attr, r=fee1-dead Remove `#[const_trait]` Remove `#[const_trait]` since we now have `const trait`. Update all structured diagnostics that still suggested the attribute. r? ```@rust-lang/project-const-traits```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
#[const_trait]since we now haveconst trait. Update all structured diagnostics that still suggested the attribute.r? @rust-lang/project-const-traits