Skip to content

[bootstrap] Make --open option work with doc src/tools/error_index_generator #148644

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[bootstrap] Make --open option work with doc src/tools/error_index_generator #148644

wants to merge 1 commit into from
+4 −1

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Nov 7, 2025 •
edited by rustbot
Loading

Fixes #148557.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 7, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 7, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 7, 2025
Open
@Kobzol
Copy link
Member

Kobzol commented Nov 7, 2025

Thanks!

r? @Kobzol

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

📌 Commit fdced17 has been approved by Kobzol

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Nov 7, 2025

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 8, 2025
@jhpratt
Rollup merge of rust-lang#148644 - GuillaumeGomez:error-index-index-o…
af8636b 
…pen, r=Kobzol

[bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`

Fixes rust-lang#148557.
@jhpratt jhpratt mentioned this pull request Nov 8, 2025
Closed
bors added a commit that referenced this pull request Nov 8, 2025
@bors
Auto merge of #148681 - jhpratt:rollup-t14sr2j, r=jhpratt
b99666a 
Rollup of 15 pull requests

Successful merges:

 - #147404 (Fix issue with callsite inline attribute not being applied sometimes.)
 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148020 (Show backtrace on allocation failures when possible)
 - #148204 (Modify contributor email entries in .mailmap)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)
 - #148612 (Add note for identifier with attempted hygiene violation)
 - #148613 (Switch hexagon targets to rust-lld)
 - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`)
 - #148649 (don't completely reset `HeadUsages`)
 - #148675 (Remove eslint-js from npm dependencies)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Nov 8, 2025
@jhpratt
Rollup merge of rust-lang#148644 - GuillaumeGomez:error-index-index-o…
bca91c6 
…pen, r=Kobzol

[bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`

Fixes rust-lang#148557.
@jhpratt jhpratt mentioned this pull request Nov 8, 2025
Closed
bors added a commit that referenced this pull request Nov 8, 2025
@bors
Auto merge of #148686 - jhpratt:rollup-jlh9fj9, r=jhpratt
939844a 
Rollup of 16 pull requests

Successful merges:

 - #147534 (Implement SIMD funnel shifts in const-eval/Miri)
 - #147686 (update isolate_highest_one for NonZero<T>)
 - #148020 (Show backtrace on allocation failures when possible)
 - #148204 (Modify contributor email entries in .mailmap)
 - #148230 (rustdoc: Properly highlight shebang, frontmatter & weak keywords in source code pages and code blocks)
 - #148279 (rustc_builtin_macros: rename bench parameter to avoid collisions with user-defined function names)
 - #148555 (Fix rust-by-example spanish translation)
 - #148556 (Fix suggestion for returning async closures)
 - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability)
 - #148600 (re-use `self.get_all_attrs` result for pass indirectly attribute)
 - #148612 (Add note for identifier with attempted hygiene violation)
 - #148613 (Switch hexagon targets to rust-lld)
 - #148619 (Enable std locking functions on AIX)
 - #148644 ([bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`)
 - #148649 (don't completely reset `HeadUsages`)
 - #148675 (Remove eslint-js from npm dependencies)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#148644 - GuillaumeGomez:error-index-index-o…
26a8c0e 
…pen, r=Kobzol

[bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`

Fixes rust-lang#148557.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 8, 2025
@matthiaskrgr
Rollup merge of rust-lang#148644 - GuillaumeGomez:error-index-index-o…
f7e8585 
…pen, r=Kobzol

[bootstrap] Make `--open` option work with `doc src/tools/error_index_generator`

Fixes rust-lang#148557.
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@Kobzol Kobzol

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

--open does not work with error_index_generator

5 participants

@GuillaumeGomez @rustbot @Kobzol @bors @Mark-Simulacrum