Skip to content

Conversation

@Shourya742
Copy link
Contributor

This PR updates the bootstrap readme and makes it consistent with the latest stage 0 redesign.

r? @Kobzol

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Nov 5, 2025
@Shourya742 Shourya742 force-pushed the 2025-11-05-update-bootstrap-documentation branch from 8a4cfa1 to ebe6c4c Compare November 9, 2025 12:44
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Copy link
Member

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checks (for example, verifying toolchains and paths), and then prepares to build the
stage 1 compiler and libraries using the prebuilt stage 0 compiler.
3. The stage 0 compiler and standard library, downloaded earlier, are used to build the
stage 1 compiler, which links against the beta standard library. The newly built stage 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
stage 1 compiler, which links against the beta standard library. The newly built stage 1
stage 1 compiler, which links against the stage 0 standard library. The newly built stage 1

Let's use consistent terminology here. It might not be beta if you overrode the stage0 rustc.

@Kobzol
Copy link
Member

Kobzol commented Nov 9, 2025

You can r=me after fixing the nit.

@bors delegate+

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

✌️ @Shourya742, you can now approve this pull request!

If @Kobzol told you to "r=me" after making some further change, please make that change, then do @bors r=@Kobzol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants