compiletest: Remove cleanup_debug_info_options
#148194
Merged
+0
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`.
Collaborator
|
Some changes occurred in src/tools/compiletest cc @jieyouxu |
rustbot
added
A-compiletest
Collaborator
|
|
Member
Author
|
Some relevant ancient commits introducing the removed code: |
Member
Author
|
@bors try jobs=x86_64-msvc-1,i686-msvc-1,aarch64-msvc-1,x86_64-mingw-1,test-various,armhf-gnu,aarch64-apple |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Oct 28, 2025
compiletest: Remove `cleanup_debug_info_options` try-job: x86_64-msvc-1 try-job: i686-msvc-1 try-job: aarch64-msvc-1 try-job: x86_64-mingw-1 try-job: test-various try-job: armhf-gnu try-job: aarch64-apple
Member
Author
I have a few more compiletest PRs that I plan to open (big and small), so I understand if it takes some time to get around to all of them. Thanks for your good work! 💖 |
Member
Yeah that is perfectly fine, it'll just take some time for me to get through them. |
jieyouxu
approved these changes
Nov 1, 2025
Member
|
Thanks |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 1, 2025
compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
bors
added a commit
that referenced
this pull request
Nov 1, 2025
Rollup of 8 pull requests Successful merges: - #147137 (Mention crate being analyzed in query description) - #148099 (Prepare to move debugger discovery from compiletest to bootstrap) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs) - #148247 (Remove two special cases from reachable_non_generics) - #148290 (Do not emit solver errors that contain error types) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) r? `@ghost` `@rustbot` modify labels: rollup
Member
Author
|
Possibly failed in rollup: #148368 (comment) @bors r- |
bors
added
S-waiting-on-author
Member
Author
|
@bors try jobs=arm-android |
This comment has been minimized.
This comment has been minimized.
rust-bors bot
added a commit
that referenced
this pull request
Nov 2, 2025
compiletest: Remove `cleanup_debug_info_options` try-job: arm-android
Member
Author
Collaborator
bors
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Nov 2, 2025
compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
bors
added a commit
that referenced
this pull request
Nov 2, 2025
Rollup of 12 pull requests Successful merges: - #147137 (Mention crate being analyzed in query description) - #147642 (Miscellaneous const-generics-related fixes) - #147806 (Ignore test-dashboard related files) - #147947 (Implement `strip_circumfix` lib feature) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148247 (Remove two special cases from reachable_non_generics) - #148348 (dangling ptr lint cleanup) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) - #148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 2, 2025
compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Nov 2, 2025
compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
bors
added a commit
that referenced
this pull request
Nov 2, 2025
Rollup of 9 pull requests Successful merges: - #147947 (Implement `strip_circumfix` lib feature) - #148170 (split definition and use site hidden tys) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs) - #148290 (Do not emit solver errors that contain error types) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Nov 2, 2025
compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
This was referenced Nov 2, 2025
bors
added a commit
that referenced
this pull request
Nov 2, 2025
Rollup of 8 pull requests Successful merges: - #148170 (split definition and use site hidden tys) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148290 (Do not emit solver errors that contain error types) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) - #148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
that referenced
this pull request
Nov 2, 2025
Rollup merge of #148194 - Zalathar:no-cleanup, r=jieyouxu compiletest: Remove `cleanup_debug_info_options` This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to `--host-rustcflags` or `--target-rustcflags`. I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice. In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating `TestCx`, which is the biggest win. r? jieyouxu
Member
Author
|
Bors, this was already merged. @bors r- |
bors
added
S-waiting-on-author
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Nov 3, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#148170 (split definition and use site hidden tys) - rust-lang/rust#148194 (compiletest: Remove `cleanup_debug_info_options`) - rust-lang/rust#148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - rust-lang/rust#148290 (Do not emit solver errors that contain error types) - rust-lang/rust#148357 (temporary-lifetime-extension.rs test works in all editions) - rust-lang/rust#148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - rust-lang/rust#148367 (Use --print host-tuple to get the host) - rust-lang/rust#148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This "cleanup" function is more than a decade old, and I can't find any evidence of modern-day bootstrap being able to pass any of these flags to
--host-rustcflagsor--target-rustcflags.I thought about replacing the cleanup with an assertion, but I think it's better to delete it entirely for now, and re-add checks later if they're motivated by actual problems in practice.
In addition to deleting some old and confusing code, this also lets us remove three instances of duplicating
TestCx, which is the biggest win.r? jieyouxu