rustdoc-search: stringdex update with more packing #147002

notriddle · 2025-09-24T21:16:53Z

Before:

18M  build/x86_64-unknown-linux-gnu/doc/search.index/
57M  build/x86_64-unknown-linux-gnu/compiler-doc/search.index/

After:

16M  build/x86_64-unknown-linux-gnu/doc/search.index/
49M  build/x86_64-unknown-linux-gnu/compiler-doc/search.index/

CC #146063

Before: 18M build/x86_64-unknown-linux-gnu/doc/search.index/ 57M build/x86_64-unknown-linux-gnu/compiler-doc/search.index/ After: 16M build/x86_64-unknown-linux-gnu/doc/search.index/ 49M build/x86_64-unknown-linux-gnu/compiler-doc/search.index/

rustbot · 2025-09-24T21:16:56Z

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat

rustbot · 2025-09-24T21:16:58Z

r? @GuillaumeGomez

rustbot has assigned @GuillaumeGomez.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

notriddle · 2025-09-24T21:17:07Z

@bors try @rust-timer queue

rustdoc-search: stringdex update with more packing

rust-bors · 2025-09-24T23:30:30Z

☀️ Try build successful (CI)
Build commit: b0e250f (b0e250fdaaaf4b26963739e05cceed88959ff0c9, parent: 15283f6fe95e5b604273d13a428bab5fc0788f5a)

rust-timer · 2025-09-25T00:40:21Z

Finished benchmarking commit (b0e250f): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.4%	[-5.6%, -0.1%]	8
Improvements ✅ (secondary)	-0.6%	[-3.1%, -0.0%]	6
All ❌✅ (primary)	-1.4%	[-5.6%, -0.1%]	8

Max RSS (memory usage)

Results (secondary 0.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.5%	[0.5%, 0.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 3.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.7%, 3.3%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.213s -> 471.314s (0.02%)
Artifact size: 387.83 MiB -> 387.90 MiB (0.02%)

GuillaumeGomez · 2025-09-25T10:42:11Z

Wow, congrats for the perf gains!

@bors r+ rollup=iffy

bors · 2025-09-25T10:42:14Z

📌 Commit 5bec161 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…omez rustdoc-search: stringdex update with more packing Before: 18M build/x86_64-unknown-linux-gnu/doc/search.index/ 57M build/x86_64-unknown-linux-gnu/compiler-doc/search.index/ After: 16M build/x86_64-unknown-linux-gnu/doc/search.index/ 49M build/x86_64-unknown-linux-gnu/compiler-doc/search.index/ CC rust-lang#146063

Rollup of 16 pull requests Successful merges: - #142139 (Include additional hashes in src/stage0) - #146745 (Clarified error note for usize range matching) - #146763 (cg_llvm: Replace some DIBuilder wrappers with LLVM-C API bindings (part 5)) - #146788 (chore: removes deprecated discord.) - #146942 ([rustdoc] Finish getting rid of usages `write_str`) - #147002 (rustdoc-search: stringdex update with more packing) - #147061 (fix rebasing cycle heads when not reaching a fixpoint) - #147066 (Fix tracking issue number for feature(macro_attr)) - #147081 (doc: fix a typo in platform-support.md) - #147082 (formatting_options: fix alternate docs 0b/0o mixup) - #147086 (compiletest: Use `PanicHookInfo::payload_as_str` now that it's stable in beta) - #147092 (Do not compute optimized MIR if code does not type-check.) - #147093 (redox: switch to colon as path separator) - #147095 (Library: Remove remaining private `#[repr]` workarounds) - #147098 (Add auto extra-checks in pre-push hook) - #147110 (Fix typo) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2025-09-28T13:29:29Z

⌛ Testing commit 5bec161 with merge 8d72d3e...

bors · 2025-09-28T16:35:06Z

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 8d72d3e to master...

github-actions · 2025-09-28T16:38:40Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing a00a515 (parent) -> 8d72d3e (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 8d72d3e1e96f58ca10059a6bb6e8aecba4a0e9cd --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

tidy: 186.7s -> 162.7s (-12.8%)
dist-sparcv9-solaris: 4994.7s -> 5539.2s (10.9%)
dist-s390x-linux: 4802.6s -> 5316.1s (10.7%)
aarch64-apple: 5067.6s -> 4687.7s (-7.5%)
dist-aarch64-apple: 6503.4s -> 6055.3s (-6.9%)
aarch64-gnu-llvm-20-2: 2319.9s -> 2166.9s (-6.6%)
aarch64-gnu-debug: 3760.0s -> 4007.4s (6.6%)
pr-check-1: 1456.1s -> 1364.2s (-6.3%)
x86_64-rust-for-linux: 2561.1s -> 2711.2s (5.9%)
dist-x86_64-musl: 8162.5s -> 7691.0s (-5.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-09-28T18:02:35Z

Finished benchmarking commit (8d72d3e): comparison URL.

Overall result: ❌✅ regressions and improvements - please read the text below

Our benchmarks found a performance regression caused by this PR.
This might be an actual regression, but it can also be just noise.

Next Steps:

If the regression was expected or you think it can be justified,
please write a comment with sufficient written justification, and add
@rustbot label: +perf-regression-triaged to it, to mark the regression as triaged.
If you think that you know of a way to resolve the regression, try to create
a new PR with a fix for the regression.
If you do not understand the regression or you think that it is just noise,
you can ask the @rust-lang/wg-compiler-performance working group for help (members of this group
were already notified of this PR).

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.3%	[0.3%, 0.3%]	1
Improvements ✅ (primary)	-1.9%	[-5.8%, -0.2%]	6
Improvements ✅ (secondary)	-1.2%	[-3.1%, -0.1%]	3
All ❌✅ (primary)	-1.9%	[-5.8%, -0.2%]	6

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary -2.2%, secondary 2.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-2.2%	[-2.2%, -2.1%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.2%	[-2.2%, -2.1%]	2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.329s -> 469.737s (-0.13%)
Artifact size: 387.69 MiB -> 387.61 MiB (-0.02%)

Mark-Simulacrum · 2025-09-29T02:31:43Z

Regression is just bimodality.

[stable] Prepare Rust 1.91.0 release - [beta-1.91] Add more context to the temporary lifetime extension FCW #148174 - rustdoc-search: JavaScript optimization based on Firefox Profiler output #146484 - rustdoc-search: use the same ID for entry and path to same item #147045 - rustdoc-search: stringdex update with more packing #147002 - rustdoc-search: stringdex 0.0.2 #147660 - [beta] Clippy beta backport #148029 - 1.91.0 release notes #148013 r? cuviper

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 24, 2025

rustbot assigned GuillaumeGomez Sep 24, 2025

rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Sep 24, 2025

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Sep 24, 2025

Auto merge of #147002 - notriddle:stringdex3, r=<try>

b0e250f

rustdoc-search: stringdex update with more packing

This comment has been minimized.

Sign in to view

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 24, 2025

This comment has been minimized.

Sign in to view

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Sep 25, 2025

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 25, 2025

Zalathar mentioned this pull request Sep 28, 2025

Rollup of 16 pull requests #147114

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 28, 2025

bors merged commit 8d72d3e into rust-lang:master Sep 28, 2025
12 checks passed

rustbot added this to the 1.92.0 milestone Sep 28, 2025

rustbot added the perf-regression Performance regression. label Sep 28, 2025

Mark-Simulacrum removed the perf-regression Performance regression. label Sep 29, 2025

Zalathar mentioned this pull request Sep 29, 2025

Searching nightly-rustc docs is broken: "Unhandled Promise Rejection: Error: not a roaring bitmap: 101" #147142

Closed

notriddle deleted the stringdex3 branch October 14, 2025 05:20

GuillaumeGomez mentioned this pull request Oct 27, 2025

cargo doc in large workspace is 10 times slower on nightly #146895

Open

GuillaumeGomez added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2025

cuviper added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 27, 2025

cuviper mentioned this pull request Oct 27, 2025

[stable] Prepare Rust 1.91.0 release #148179

Merged

cuviper modified the milestones: 1.92.0, 1.91.0 Oct 27, 2025

cuviper removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 27, 2025

rustdoc-search: stringdex update with more packing #147002

rustdoc-search: stringdex update with more packing #147002

Uh oh!

Conversation

notriddle commented Sep 24, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 24, 2025

Uh oh!

rustbot commented Sep 24, 2025

Uh oh!

notriddle commented Sep 24, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Sep 24, 2025

Uh oh!

This comment has been minimized.

rust-timer commented Sep 25, 2025

Overall result: ✅ improvements - no action needed

Uh oh!

GuillaumeGomez commented Sep 25, 2025

Uh oh!

bors commented Sep 25, 2025

Uh oh!

bors commented Sep 28, 2025

Uh oh!

bors commented Sep 28, 2025

Uh oh!

Uh oh!

github-actions bot commented Sep 28, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Sep 28, 2025

Overall result: ❌✅ regressions and improvements - please read the text below

Uh oh!

Mark-Simulacrum commented Sep 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

notriddle commented Sep 24, 2025 •

edited by rustbot

Loading