Skip to content

Conversation

@Mark-Simulacrum
Copy link
Member

This unconditionally uses the provided LLVM toolchain's BOLT. I'm not sure that makes sense, but since we don't build BOLT as part of Rust's build of LLVM today, it's probably the right option for now.

This avoids breaking the build on not being able to find the llvm-bolt executable.

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

kobzol is not on the review rotation at the moment.
They may take a while to respond.

@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

r? @Kobzol

rustbot has assigned @Kobzol.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 30, 2025
@rustbot
Copy link
Collaborator

rustbot commented Aug 30, 2025

Some changes occurred in src/tools/opt-dist

cc @Kobzol

@Kobzol
Copy link
Member

Kobzol commented Aug 30, 2025

@bors try

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Aug 30, 2025
Use absolute path to llvm-bolt rather than PATH
@rust-log-analyzer

This comment has been minimized.

@rust-bors
Copy link

rust-bors bot commented Aug 30, 2025

💔 Test for 217b626 failed: CI. Failed jobs:

This unconditionally uses the provided LLVM toolchain's BOLT. I'm not
sure that makes sense, but since we don't build BOLT as part of Rust's
build of LLVM today, it's probably the right option for now.

This avoids breaking the build on not being able to find the llvm-bolt
executable.
@Mark-Simulacrum
Copy link
Member Author

@bors try

Found merge-fdata had the same problem, included a fix for that in the push.

@rust-bors

This comment has been minimized.

rust-bors bot added a commit that referenced this pull request Aug 30, 2025
Use absolute path to llvm-bolt rather than PATH
@Mark-Simulacrum Mark-Simulacrum changed the title Use absolute path to llvm-bolt rather than PATH Use absolute path to llvm-bolt, merge-fdata rather than PATH Aug 30, 2025
@rust-bors
Copy link

rust-bors bot commented Aug 31, 2025

☀️ Try build successful (CI)
Build commit: 9c863c2 (9c863c222b43a8b970588d78cbb0486965885e98, parent: 523d3999dcd4bbd9a52661a29dbd7351a9c5fb03)

@Kobzol
Copy link
Member

Kobzol commented Aug 31, 2025

Thanks!

@bors r+

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

📌 Commit 199d2d4 has been approved by Kobzol

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 31, 2025
@bors
Copy link
Collaborator

bors commented Aug 31, 2025

⌛ Testing commit 199d2d4 with merge 1bc901e...

@bors
Copy link
Collaborator

bors commented Aug 31, 2025

☀️ Test successful - checks-actions
Approved by: Kobzol
Pushing 1bc901e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Aug 31, 2025
@bors bors merged commit 1bc901e into rust-lang:master Aug 31, 2025
12 checks passed
@rustbot rustbot added this to the 1.91.0 milestone Aug 31, 2025
@github-actions
Copy link
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 64a99db (parent) -> 1bc901e (this PR)

Test differences

Show 4 test diffs

4 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 1bc901e0cab0f150e3bcdb9e7cf99ab085682b3e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. pr-check-1: 1704.1s -> 1369.2s (-19.6%)
  2. x86_64-gnu-llvm-19: 2817.5s -> 2386.3s (-15.3%)
  3. x86_64-rust-for-linux: 2931.8s -> 2488.8s (-15.1%)
  4. aarch64-apple: 5928.7s -> 5138.6s (-13.3%)
  5. aarch64-gnu-llvm-19-1: 3725.1s -> 3333.2s (-10.5%)
  6. x86_64-gnu-llvm-19-1: 3727.4s -> 3346.3s (-10.2%)
  7. x86_64-gnu-tools: 3725.8s -> 3368.9s (-9.6%)
  8. i686-gnu-1: 8304.4s -> 7510.6s (-9.6%)
  9. arm-android: 6359.0s -> 5773.9s (-9.2%)
  10. aarch64-gnu: 7559.7s -> 6880.5s (-9.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (1bc901e): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-0.2% [-0.2%, -0.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
2.4% [2.4%, 2.4%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.2% [-2.2%, -2.2%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.1% [-2.2%, 2.4%] 2

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 466.641s -> 468.036s (0.30%)
Artifact size: 388.58 MiB -> 388.54 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants