-
Notifications
You must be signed in to change notification settings - Fork 14k
Use absolute path to llvm-bolt, merge-fdata rather than PATH #146039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
|
Some changes occurred in src/tools/opt-dist cc @Kobzol |
|
@bors try |
This comment has been minimized.
This comment has been minimized.
Use absolute path to llvm-bolt rather than PATH
This comment has been minimized.
This comment has been minimized.
|
💔 Test for 217b626 failed: CI. Failed jobs:
|
This unconditionally uses the provided LLVM toolchain's BOLT. I'm not sure that makes sense, but since we don't build BOLT as part of Rust's build of LLVM today, it's probably the right option for now. This avoids breaking the build on not being able to find the llvm-bolt executable.
ef50c49 to
199d2d4
Compare
|
@bors try Found merge-fdata had the same problem, included a fix for that in the push. |
This comment has been minimized.
This comment has been minimized.
Use absolute path to llvm-bolt rather than PATH
|
Thanks! @bors r+ |
|
☀️ Test successful - checks-actions |
What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 64a99db (parent) -> 1bc901e (this PR) Test differencesShow 4 test diffs4 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \
test-dashboard 1bc901e0cab0f150e3bcdb9e7cf99ab085682b3e --output-dir test-dashboardAnd then open Job duration changes
How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance |
|
Finished benchmarking commit (1bc901e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResults (primary 0.1%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 466.641s -> 468.036s (0.30%) |
This unconditionally uses the provided LLVM toolchain's BOLT. I'm not sure that makes sense, but since we don't build BOLT as part of Rust's build of LLVM today, it's probably the right option for now.
This avoids breaking the build on not being able to find the llvm-bolt executable.