tests/ui: A New Order [26/N]
#143301
Merged
tests/ui: A New Order [26/N]
#143301
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Member
Author
|
If it'll help, I can squash commits in advance |
Contributor
|
Would you mind doing that? GH seems to be struggling with this diff again for some reason |
Member
Author
|
Squashed this and last part |
tgross35
requested changes
Jul 9, 2025
rustbot
added
S-waiting-on-author
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@rustbot ready |
rustbot
added
S-waiting-on-review
tgross35
reviewed
Jul 10, 2025
Contributor
tgross35
left a comment
tgross35
left a comment
There was a problem hiding this comment.
Just a few small spelling nits.
Also, could you update the second commit message to say "Additionally, remove unused tests/ui/auxiliary/svh-* crates that are duplicates of tests/ui/svh/auxiliary/svh-*." or otherwise mention the exact paths? So nobody has to dig to find that out, it was a bit tricky to get that info
tgross35
approved these changes
Jul 10, 2025
Contributor
|
Thanks! |
Collaborator
bors
added
S-waiting-on-bors
Collaborator
|
☔ The latest upstream changes (presumably #143762) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Additionally, remove unused `tests/ui/auxiliary/svh-*` crates that are duplicates of `tests/ui/svh/auxiliary/svh-*`.
Contributor
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
This was referenced Jul 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Intermediate commits are intended to help review, but will be squashed prior to merge.
Some
tests/ui/housekeeping, to trim down number of tests directly undertests/ui/. Part of #133895.r? @tgross35