-
Notifications
You must be signed in to change notification settings - Fork 14k
Update bundled musl to 1.2.5 #142682
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled musl to 1.2.5 #142682
Conversation
|
These commits modify compiler targets. Some changes occurred in src/doc/rustc/src/platform-support cc @Noratrieb |
|
The previous PR stalled out on concerns of ecosystem breakage, but see this comment for @est31 concluding we can move forward without further mitigation: #125692 (comment) |
|
I would like to nominate this for FCP or whatever the current process is to land these kinds of major toolchain changes. Landing this update is expected to resolve ongoing issues in the ecosystem with rootless docker images. I've also drafted a rust-lang blogpost announcing this change (based on the previous musl update's post). |
|
The process for bumping the target baseline of Tier 2 targets is currently a Major Change Proposal + FCP (see Changing target baseline (e.g. minimum Darwin or Windows version bump) part). If you draft an MCP, I'll help with the notifying relevant target maintainers part.
|
|
r? @wesleywiser (since you've reviewed the previous attempt) |
|
I have filed an MCP: |
|
Building host compiler plus musl stds for crater run. @bors try |
Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. [musl releases page](https://musl.libc.org/releases.html) Prior update: #107129 MCP for this change: rust-lang/compiler-team#887 -------- This is a rebase of * #125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
|
💥 Test timed out |
This comment has been minimized.
This comment has been minimized.
|
@bors2 delegate=try |
|
@Gankra can now perform try builds on this pull request |
This comment was marked as outdated.
This comment was marked as outdated.
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
|
LOUD SIREN NOISES IT'S TIME |
|
It seems it is indeed time~ @bors r=wesleywiser |
…wiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: rust-lang#107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * rust-lang#125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
…wiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: rust-lang#107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * rust-lang#125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
…wiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: rust-lang#107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * rust-lang#125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
…wiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: rust-lang#107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * rust-lang#125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
…wiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: rust-lang#107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * rust-lang#125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
Rollup of 10 pull requests Successful merges: - #135602 (Tweak output of missing lifetime on associated type) - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`) - #142682 (Update bundled musl to 1.2.5) - #148171 (Simplify code to generate line numbers in highlight) - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`) - #148301 ([rustdoc search] Include extern crates when filtering on `import`) - #148330 (Don't require dlltool with the dummy backend on MinGW) - #148338 (cleanup: upstream dropped amx-transpose functionality) - #148340 (Clippy subtree update) - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference) r? `@ghost` `@rustbot` modify labels: rollup
Rollup of 10 pull requests Successful merges: - #135602 (Tweak output of missing lifetime on associated type) - #139751 (Implement pin-project in pattern matching for `&pin mut|const T`) - #142682 (Update bundled musl to 1.2.5) - #148171 (Simplify code to generate line numbers in highlight) - #148263 (Unpin `libc` and `rustix` in `compiler` and `rustbook`) - #148301 ([rustdoc search] Include extern crates when filtering on `import`) - #148330 (Don't require dlltool with the dummy backend on MinGW) - #148338 (cleanup: upstream dropped amx-transpose functionality) - #148340 (Clippy subtree update) - #148343 (`nonpoison::Condvar` should take `MutexGuard` by reference) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of #142682 - Gankra:update_musl_1.2.5, r=wesleywiser Update bundled musl to 1.2.5 Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024. * mcp: rust-lang/compiler-team#887 * blog: rust-lang/blog.rust-lang.org#1641 * Prior update: #107129 * [musl releases page](https://musl.libc.org/releases.html) -------- This is a rebase of * #125692 Which removes the second speculative commit which ended up not panning out. I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase. try-job: dist-x86_64-musl try-job: dist-i586-gnu-i586-i686-musl try-job: dist-x86_64-linux
Update the bundled musl library from 1.2.3 to the 1.2.5 release from February 29, 2024.
*-linux-musltargets to musl 1.2.5 compiler-team#887*-linux-musltargets to 1.2.3 #107129This is a rebase of
Which removes the second speculative commit which ended up not panning out.
I've added my own second commit that updates all other places I could find that referenced musl 1.2.3 in the codebase.
try-job: dist-x86_64-musl
try-job: dist-i586-gnu-i586-i686-musl
try-job: dist-x86_64-linux