bootstrap: Remove bin_root from PATH

[petrochenkov]

It's not currently load bearing in typical setups on typical targets.
Basically, if it passes the standard CI, then we can remove it, I think.

If someone later reports this breaking the build, then we can address it in a more fine grained way.
E.g. add it to PATH last and not first, only on specific targets, and only if specific files are not already found in PATH directories.

Fixes #t-infra/bootstrap > Build broken in MSYS2 @ 💬

[rustbot]

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

This seems reasonable. If someone ends up complaining... revert is an option.

[jieyouxu]

r? jieyouxu @bors r+ rollup=iffy

[bors]

📌 Commit 043b164 has been approved by jieyouxu

It is now in the queue for this repository.

[bors]

⌛ Testing commit 043b164 with merge 70b3f46...

[bors]

☀️ Test successful - checks-actions
Approved by: jieyouxu
Pushing 70b3f46 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 15825b7 (parent) -> 70b3f46 (this PR)

Test differences

No test diffs found

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 70b3f4666e24ce22fc32f5e357dbcf85d3254e63 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. dist-aarch64-apple: 4819.7s -> 6340.1s (31.5%)
2. x86_64-apple-1: 10726.8s -> 7386.1s (-31.1%)
3. dist-apple-various: 10260.3s -> 7457.8s (-27.3%)
4. dist-x86_64-msvc-alt: 8772.5s -> 7360.1s (-16.1%)
5. dist-x86_64-apple: 9551.7s -> 11027.0s (15.4%)
6. aarch64-apple: 5648.4s -> 5067.7s (-10.3%)
7. dist-riscv64-linux: 5734.1s -> 5258.8s (-8.3%)
8. dist-aarch64-linux: 5312.7s -> 5672.6s (6.8%)
9. dist-x86_64-illumos: 5729.7s -> 6111.5s (6.7%)
10. x86_64-gnu-aux: 5915.3s -> 5616.2s (-5.1%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (70b3f46): comparison URL.

Overall result: ❌ regressions - no action needed

@rustbot label: -perf-regression

Instruction count

This is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.6%	[0.6%, 0.6%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (secondary 0.2%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.4%, 0.9%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.6%	[-0.7%, -0.4%]	4
All ❌✅ (primary)	-	-	0

Cycles

Results (secondary 0.3%)

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.7%	[0.5%, 1.2%]	12
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.4%, -0.7%]	4
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 778.613s -> 778.921s (0.04%)
Artifact size: 370.16 MiB -> 370.25 MiB (0.02%)