Skip to content

Stabilize once_wait #136360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2025
Merged

Stabilize once_wait #136360

merged 1 commit into from
Feb 1, 2025

Conversation

@slanterns
Copy link
Contributor

@slanterns slanterns commented Jan 31, 2025

Closes: #127527.

@rustbot label: +T-libs-api

r? libs-api

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jan 31, 2025
@tgross35
Copy link
Contributor

tgross35 commented Feb 1, 2025

libs-api doesn't need to review stabilization PRs if nothing changes, as long as their FCP completed.

r? tgross35
@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 1, 2025

📌 Commit 6fa6168 has been approved by tgross35

It is now in the queue for this repository.

@rustbot rustbot assigned tgross35 and unassigned joshtriplett Feb 1, 2025
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 1, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 1, 2025
Merged
@bors bors merged commit cbcb695 into rust-lang:master Feb 1, 2025
6 checks passed
@rustbot rustbot added this to the 1.86.0 milestone Feb 1, 2025
@slanterns slanterns deleted the once_wait branch February 2, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tgross35 tgross35 tgross35 approved these changes

Assignees

@tgross35 tgross35

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.86.0

Development

Successfully merging this pull request may close these issues.

Tracking Issue for once_wait

5 participants

@slanterns @tgross35 @bors @joshtriplett @rustbot