Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 #131955

SpriteOvO · 2024-10-20T01:13:04Z

This PR contains 3 commits:

the first one introduces a new function adjust_for_rust_abi in rustc_target, and moves the x86 specific adjustment code into it;
the second one adds RISC-V specific adjustment code into it, which sets signext or zeroext attribute for integer arguments.
UPDATE: added the 3rd commit to apply the same adjustment for LoongArch64.

Fixes #114508.

r? @workingjubilee
CC @coastalwhite @Urgau @topperc @michaelmaitland

workingjubilee · 2024-10-20T01:41:31Z

Oh thank you for 9ba8053

tests/assembly/riscv64gc-zbb.rs

tests/codegen/checked_math.rs

tests/assembly/riscv64gc-zbb.rs

SpriteOvO · 2024-10-20T21:26:08Z

CC @xen0n since the PR contains changes about LoongArch.

tests/codegen/checked_ilog.rs

rustbot · 2024-10-21T11:37:33Z

Some changes occurred in tests/codegen/sanitizer

cc @rust-lang/project-exploit-mitigations, @rcvalle

tests/assembly/rust-abi-arg-attr.rs

tests/codegen/checked_ilog.rs

workingjubilee · 2024-10-22T00:32:29Z

@bors try

bors · 2024-10-22T00:33:39Z

⌛ Trying commit 2dfd4d0 with merge 90a40a6...

Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 Fixes rust-lang#114508. This PR contains 3 commits: - the first one introduces a new function `adjust_for_rust_abi` in `rustc_target`, and moves the x86 specific adjustment code into it; - the second one adds RISC-V specific adjustment code into it, which sets `signext` or `zeroext` attribute for integer arguments. - **UPDATE**: added the 3rd commit for apply the same adjustment for LoongArch64. r? `@workingjubilee` CC `@coastalwhite` `@Urgau` `@topperc` `@michaelmaitland` try-job: dist-loongarch64-linux try-job: dist-riscv64-linux try-job: test-various try-job: i686-gnu-nopt try-job: i686-gnu

bors · 2024-10-22T19:09:30Z

☀️ Try build successful - checks-actions
Build commit: 9736634 (973663438c19b99f2f5669a14d9cd1afcc5e908b)

SpriteOvO · 2024-10-23T01:16:40Z

Rebased to the latest master since #131871 is merged just now.

tests/assembly/rust-abi-arg-attr.rs

workingjubilee · 2024-10-23T09:13:27Z

This was the recommended implementation by @michaelmaitland here: RISC-V Codegen Problem with type information #114508 (comment)
It was recommended for the arches specified here: RISC-V Codegen Problem with type information #114508 (comment)
And the LoongArch maintainers think it's cool.

So, looks like we're good.

@bors r+

bors · 2024-10-23T09:13:29Z

📌 Commit 57bffe1 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-10-23T11:12:36Z

⌛ Testing commit 57bffe1 with merge fc0c42b...

…ingjubilee Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 This PR contains 3 commits: - the first one introduces a new function `adjust_for_rust_abi` in `rustc_target`, and moves the x86 specific adjustment code into it; - the second one adds RISC-V specific adjustment code into it, which sets `signext` or `zeroext` attribute for integer arguments. - **UPDATE**: added the 3rd commit to apply the same adjustment for LoongArch64.

rust-log-analyzer · 2024-10-23T12:14:54Z

The job dist-x86_64-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[2024-10-23T11:57:16Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-23T11:57:16Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T11:57:16Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpawAcqi#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-23T11:57:17Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T11:57:17Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpawAcqi#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpawAcqi\\incremental-state"
[2024-10-23T11:57:19Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T11:57:19Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpawAcqi#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpawAcqi\\incremental-state"
[2024-10-23T11:57:19Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpawAcqi"
[2024-10-23T11:57:19Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-10-23T11:57:19Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-10-23T11:57:19Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpawAcqi#[email protected]" "--release" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpawAcqi\\incremental-state"
Executing benchmark cargo-0.60.0 (2/8)
Preparing cargo-0.60.0
[2024-10-23T11:57:21Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None, backend=Llvm, phase=dependencies
[2024-10-23T11:57:21Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None, backend=Llvm, phase=dependencies
---
[2024-10-23T12:01:17Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-23T12:01:19Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Opt, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:01:19Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpcbiAPf#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-23T12:02:17Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:02:17Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpcbiAPf#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpcbiAPf\\incremental-state"
[2024-10-23T12:03:17Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:03:17Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpcbiAPf#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpcbiAPf\\incremental-state"
[2024-10-23T12:03:23Z DEBUG collector::compile::benchmark::patch] applying println to "C:\\a\\_temp\\msys64\\tmp\\.tmpcbiAPf"
[2024-10-23T12:03:23Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-10-23T12:03:23Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Opt, scenario=Some(IncrPatched), patch=Some(Patch { index: 0, name: PatchName("println"), path: "0-println.patch" }), backend=Llvm, phase=benchmark
[2024-10-23T12:03:23Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpcbiAPf#[email protected]" "--release" "--lib" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpcbiAPf\\incremental-state"
Executing benchmark ctfe-stress-5 (3/8)
Preparing ctfe-stress-5
[2024-10-23T12:03:33Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=None, patch=None, backend=Llvm, phase=dependencies
[2024-10-23T12:03:33Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=None, patch=None, backend=Llvm, phase=dependencies
---
[2024-10-23T12:03:33Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-23T12:03:33Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Check, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:03:33Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpAEbgVY#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-23T12:03:38Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:03:38Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpAEbgVY#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpAEbgVY\\incremental-state"
[2024-10-23T12:03:44Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Check, scenario=Some(IncrUnchanged), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:03:44Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpAEbgVY#[email protected]" "--profile" "check" "--" "--wrap-rustc-with" "Eprintln" "-C" "incremental=C:\\a\\_temp\\msys64\\tmp\\.tmpAEbgVY\\incremental-state"
[2024-10-23T12:03:45Z DEBUG collector::compile::benchmark] Benchmark iteration 1/1
[2024-10-23T12:03:45Z INFO  collector::compile::execute] run_rustc with incremental=false, profile=Debug, scenario=Some(Full), patch=None, backend=Llvm, phase=benchmark
[2024-10-23T12:03:45Z DEBUG collector::compile::execute] "\\\\?\\C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage0\\bin\\cargo.exe" "rustc" "--manifest-path" "Cargo.toml" "-p" "path+file:///C:/a/_temp/msys64/tmp/.tmpe5VY2C#[email protected]" "--" "--wrap-rustc-with" "Eprintln"
[2024-10-23T12:03:50Z INFO  collector::compile::execute] run_rustc with incremental=true, profile=Debug, scenario=Some(IncrFull), patch=None, backend=Llvm, phase=benchmark
---
   Compiling rustc_driver v0.0.0 (C:\a\rust\rust\compiler\rustc_driver)
[RUSTC-TIMING] rustc_driver test:false 4.676
error: linking with `link.exe` failed: exit code: 1104
  |
  = note: "C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\bin\\HostX64\\x64\\link.exe" "/NOLOGO" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\symbols.o" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-b9d4af25c456c3b7.rustc_main.dbd68976230aa633-cgu.0.rcgu.o" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_driver-f9c873b4f7cd2164.dll.lib" "C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1\\lib\\rustlib\\x86_64-pc-windows-msvc\\lib\\libcompiler_builtins-312cc7332d5665e0.rlib" "psapi.lib" "shell32.lib" "ole32.lib" "uuid.lib" "advapi32.lib" "ws2_32.lib" "ntdll.lib" "kernel32.lib" "advapi32.lib" "ole32.lib" "oleaut32.lib" "advapi32.lib" "cfgmgr32.lib" "gdi32.lib" "kernel32.lib" "msimg32.lib" "opengl32.lib" "user32.lib" "winspool.lib" "bcrypt.lib" "advapi32.lib" "legacy_stdio_definitions.lib" "kernel32.lib" "kernel32.lib" "advapi32.lib" "ntdll.lib" "userenv.lib" "ws2_32.lib" "dbghelp.lib" "/defaultlib:libcmt" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\advapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-errorhandling-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-file-fromapp-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-handle-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-ioring-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-5.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-7.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-memory-l1-1-8.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-synch-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-sysinfo-l1-2-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-sysinfo-l1-2-3.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-sysinfo-l1-2-4.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-sysinfo-l1-2-6.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-util-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-winrt-error-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-winrt-l1-1-0.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-core-wow64-l1-1-1.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\api-ms-win-security-base-l1-2-2.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\avrt.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\bcp47mrm.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\bcryptprimitives.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\clfsw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\dbghelp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\elscore.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\gdi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\icu.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\imagehlp.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\kernel32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\ktmw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\netapi32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\normaliz.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\ntdll.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\ntdllk.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\ole32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\oleacc.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\oleaut32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\propsys.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\psapi.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\rtworkq.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\txfw32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\user32.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\usp10.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\version.dll_imports_indirect.lib" "C:\\a\\_temp\\msys64\\tmp\\rustcFqjbX7\\wofutil.dll_imports_indirect.lib" "/NXCOMPAT" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\stacker-1c496942f5526841\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\psm-b307fe5d9726f8b1\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-4a372efeb6f355a1\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\blake3-4a372efeb6f355a1\\out" "/LIBPATH:C:\\Program Files\\Microsoft Visual Studio\\2022\\Enterprise\\VC\\Tools\\MSVC\\14.41.34120\\atlmfc\\lib\\x64" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\build\\rustc_llvm-e2958cd171cbaa3b\\out" "/LIBPATH:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\llvm\\lib" "/OUT:C:\\a\\rust\\rust\\build\\x86_64-pc-windows-msvc\\stage1-rustc\\x86_64-pc-windows-msvc\\release\\deps\\rustc_main-b9d4af25c456c3b7.exe" "/OPT:REF,ICF" "/DEBUG" "/PDBALTPATH:%_PDB%" "/MANIFEST:EMBED" "/MANIFESTINPUT:C:\\a\\rust\\rust\\compiler\\rustc\\Windows Manifest.xml" "/WX"
  = note: LINK : fatal error LNK1104: cannot open file 'C:\a\rust\rust\build\x86_64-pc-windows-msvc\stage1-rustc\x86_64-pc-windows-msvc\release\deps\rustc_main-b9d4af25c456c3b7.exe'␍

[RUSTC-TIMING] rustc_main test:false 0.654
error: could not compile `rustc-main` (bin "rustc-main") due to 1 previous error
Build completed unsuccessfully in 0:07:43

bors · 2024-10-23T12:15:33Z

💔 Test failed - checks-actions

workingjubilee · 2024-10-23T17:05:26Z

@bors retry

Rollup of 9 pull requests Successful merges: - rust-lang#130991 (Vectorized SliceContains) - rust-lang#131928 (rustdoc: Document `markdown` module.) - rust-lang#131955 (Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64) - rust-lang#131979 (Minor tweaks to `compare_impl_item.rs`) - rust-lang#132036 (Add a test case for rust-lang#131164) - rust-lang#132039 (Specialize `read_exact` and `read_buf_exact` for `VecDeque`) - rust-lang#132060 ("innermost", "outermost", "leftmost", and "rightmost" don't need hyphens) - rust-lang#132065 (Clarify documentation of `ptr::dangling()` function) - rust-lang#132066 (Fix a typo in documentation of `pointer::sub_ptr()`) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#131955 - SpriteOvO:riscv-int-arg-attr, r=workingjubilee Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 This PR contains 3 commits: - the first one introduces a new function `adjust_for_rust_abi` in `rustc_target`, and moves the x86 specific adjustment code into it; - the second one adds RISC-V specific adjustment code into it, which sets `signext` or `zeroext` attribute for integer arguments. - **UPDATE**: added the 3rd commit to apply the same adjustment for LoongArch64.

rustbot assigned workingjubilee Oct 20, 2024

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 20, 2024

SpriteOvO force-pushed the riscv-int-arg-attr branch from 0ebbea6 to 3f98b30 Compare October 20, 2024 01:18

This comment has been minimized.

Sign in to view

workingjubilee reviewed Oct 20, 2024

View reviewed changes

tests/assembly/riscv64gc-zbb.rs Outdated Show resolved Hide resolved

workingjubilee reviewed Oct 20, 2024

View reviewed changes

tests/codegen/checked_math.rs Outdated Show resolved Hide resolved

workingjubilee reviewed Oct 20, 2024

View reviewed changes

tests/assembly/riscv64gc-zbb.rs Outdated Show resolved Hide resolved

SpriteOvO force-pushed the riscv-int-arg-attr branch from 3f98b30 to 4bf70dd Compare October 20, 2024 21:17

SpriteOvO changed the title ~~Set signext or zeroext for integer arguments on RISC-V~~ Set signext or zeroext for integer arguments on RISC-V and LoongArch64 Oct 20, 2024

nikic reviewed Oct 20, 2024

View reviewed changes

tests/codegen/checked_ilog.rs Outdated Show resolved Hide resolved

workingjubilee reviewed Oct 21, 2024

View reviewed changes

tests/codegen/checked_ilog.rs Outdated Show resolved Hide resolved

SpriteOvO force-pushed the riscv-int-arg-attr branch from 4bf70dd to dfec22d Compare October 21, 2024 11:37

rustbot added the PG-exploit-mitigations Project group: Exploit mitigations label Oct 21, 2024

SpriteOvO force-pushed the riscv-int-arg-attr branch from dfec22d to 4d7528f Compare October 21, 2024 11:46

nikic reviewed Oct 21, 2024

View reviewed changes

tests/assembly/rust-abi-arg-attr.rs Show resolved Hide resolved

tests/codegen/checked_ilog.rs Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

SpriteOvO force-pushed the riscv-int-arg-attr branch from 4d7528f to 6edf712 Compare October 21, 2024 13:15

This comment has been minimized.

Sign in to view

SpriteOvO force-pushed the riscv-int-arg-attr branch 2 times, most recently from 2354fad to 2dfd4d0 Compare October 21, 2024 14:03

workingjubilee mentioned this pull request Oct 21, 2024

rust_for_linux: -Zregparm=<N> commandline flag for X86 (#116972) #130432

Merged

workingjubilee added O-riscv Target: RISC-V architecture O-loongarch Target: LoongArch (LA32R, LA32S, LA64) A-ABI Area: Concerning the application binary interface (ABI) labels Oct 21, 2024

SpriteOvO force-pushed the riscv-int-arg-attr branch from 0adeaf3 to f8cdf3c Compare October 23, 2024 01:15

Introduce adjust_for_rust_abi in rustc_target

03df13b

SpriteOvO force-pushed the riscv-int-arg-attr branch from f8cdf3c to 294a808 Compare October 23, 2024 01:22

workingjubilee reviewed Oct 23, 2024

View reviewed changes

tests/assembly/rust-abi-arg-attr.rs Outdated Show resolved Hide resolved

tests/assembly/rust-abi-arg-attr.rs Outdated Show resolved Hide resolved

tests/assembly/rust-abi-arg-attr.rs Outdated Show resolved Hide resolved

SpriteOvO added 2 commits October 23, 2024 04:42

Set signext or zeroext for integer arguments on RISC-V

6b65524

Set signext or zeroext for integer arguments on LoongArch64

57bffe1

SpriteOvO force-pushed the riscv-int-arg-attr branch from 294a808 to 57bffe1 Compare October 23, 2024 02:42

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 23, 2024

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 23, 2024

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 23, 2024

fmease mentioned this pull request Oct 23, 2024

Rollup of 9 pull requests #132079

Merged

bors merged commit a144561 into rust-lang:master Oct 24, 2024
6 of 7 checks passed

rustbot added this to the 1.84.0 milestone Oct 24, 2024

SpriteOvO deleted the riscv-int-arg-attr branch October 24, 2024 01:21

workingjubilee added the CI-spurious-fail-msvc CI spurious failure: target env msvc label Nov 2, 2024

Set signext or zeroext for integer arguments on RISC-V and LoongArch64 #131955

Set signext or zeroext for integer arguments on RISC-V and LoongArch64 #131955

Uh oh!

Conversation

SpriteOvO commented Oct 20, 2024 • edited by workingjubilee Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

workingjubilee commented Oct 20, 2024

Uh oh!

This comment has been minimized.

Uh oh!

Uh oh!

Uh oh!

SpriteOvO commented Oct 20, 2024

Uh oh!

Uh oh!

Uh oh!

rustbot commented Oct 21, 2024

Uh oh!

Uh oh!

Uh oh!

This comment has been minimized.

This comment has been minimized.

workingjubilee commented Oct 22, 2024

Uh oh!

bors commented Oct 22, 2024

Uh oh!

bors commented Oct 22, 2024

Uh oh!

SpriteOvO commented Oct 23, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

workingjubilee commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

rust-log-analyzer commented Oct 23, 2024

Uh oh!

bors commented Oct 23, 2024

Uh oh!

workingjubilee commented Oct 23, 2024

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 #131955

Set `signext` or `zeroext` for integer arguments on RISC-V and LoongArch64 #131955

SpriteOvO commented Oct 20, 2024 •

edited by workingjubilee

Loading