Skip to content

fix shootout-spectralnorm, broken since Arc cannot unwrap. #12766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2014
Merged

fix shootout-spectralnorm, broken since Arc cannot unwrap. #12766

merged 1 commit into from
Mar 11, 2014

Conversation

@TeXitoi
Copy link
Contributor

@TeXitoi TeXitoi commented Mar 8, 2014

No description provided.

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Mar 9, 2014

I'll comment this trick.
For (b), I prefere this version because it works even if we send something, it's clear that we do not wait for a message but for the end of the stream, and we do not need type annotation because we explicitly catch unit in the for loop. OK for the for loop?

@TeXitoi
Copy link
Contributor Author

TeXitoi commented Mar 9, 2014

Comments added.

bors added a commit that referenced this pull request Mar 11, 2014
@bors
auto merge of #12766 : TeXitoi/rust/fix-shootout-spectralnorm, r=alex…
294d3dd 
…crichton
@bors bors closed this Mar 11, 2014
@bors bors merged commit 9e49a07 into rust-lang:master Mar 11, 2014
@TeXitoi TeXitoi deleted the fix-shootout-spectralnorm branch March 12, 2014 08:20
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 25, 2022
@bors
Auto merge of rust-lang#12766 - Veykril:completion-vis, r=Veykril
2e9d5b5 
fix: Don't show qualified path completions for private items

Fixes rust-lang/rust-analyzer#12703
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TeXitoi @alexcrichton @bors