Remove some non-essential trait re-exports from the prelude. #12485
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
FWIW, |
Contributor
Author
|
Cheers @huonw, updated the PR description. |
Contributor
Author
|
rebased |
chris-morgan
added a commit
to chris-morgan/rust-http
that referenced
this pull request
Feb 27, 2014
chris-morgan
added a commit
to chris-morgan/rust-http
that referenced
this pull request
Feb 27, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaultonly contains a static method. It provides no extension methods that are commonly used in client code.FromStralready has its only static method,from_str, re-exported in the prelude. Implementing the trait itself is less common.ToStrRadixis being phased out in favor of usingstd::fmt::radix, and theto_str_radixmethod is rather specialised to warrant a global re-export.r? @brson