Ensure an error is raised on infinite recursion #12247
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
There was a problem hiding this comment.
I think that we're running tidy over tests now (or at least I think there was a PR for that), so it may be required in the future to shorten this line.
Contributor
There was a problem hiding this comment.
There's a test directive to allow long lines, but I don't recall what it is off hand.
Contributor
Author
There was a problem hiding this comment.
I was having some issues with making the printed, multi-line error match the error in the comment, which means this test kept failing.
I'd be ok to re-factor this patch or proposa a new one that makes it multi-line if that's needed.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 5, 2023
…albasi fix: ignore impls with `#[rustc_reservation_impl]` Fixes rust-lang#12247 Fixes rust-lang#14279 Currently core has two blanket impls for `From`: `impl<T> From<T> for T` and `impl<T> From<!> for T`. These are conflicting and thus chalk cannot uniquely solve `S: From<?0>` for any type `S`. The latter impl is actually a reservation impl and should not be considered during trait selection. More generally, impls attributed with perma-unstable `#[rustc_reservation_impl]` attribute should be disregarded except for coherence checks. See rust-lang#64631 and rust-lang#64715 for details. I chose to entirely ignore them in hir-ty because we don't do coherence checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8727