Skip to content

Conversation

@RalfJung
Copy link
Member

@RalfJung RalfJung commented Mar 3, 2024

r? @ghost

RalfJung and others added 30 commits February 25, 2024 10:41
Rustup

Let's see if rust-lang#121114 gets perf back to the old level.
more dealing with macOS CI runners being slow

500ms seems to still sometimes not enough... so let's double it...
…=RalfJung

tree borrows: add a test to sb_fails

This is something that happens in the wild (rust-lang#121626), so TB accepting this is good. Let's make sure we notice if this ever changes.
./miri many-seeds: support MIRI_SEED_END to control the end of the seed range
Fix miri.bat not bailing early on error

There is a logical error in the batch script that I did not think about. Currently, if the build step for miri-script fails, it will continue on and attempt to execute the next line. This will either lead to a file not found error, or running an old miri-script.

With this, it will bail upon erroring in the build step.
add mpsc memory leak to trophy case
remove a wrong bitwise negation

This is a silly mistake I introduced in rust-lang/miri@a1233a7.
RalfJung and others added 11 commits March 2, 2024 17:56
…RalfJung

print thread name in miri error backtraces; add option to track read/write accesses

This came up while debugging rust-lang#121626. It didn't end up being useful there but still seems like good tools to have around.
Tree Borrows diagnostic improvements

print where the forbidden access happens; make tag tracking less verbose
Add -Zmiri-track-alloc-accesses to readme and fix its wording

I forgot that yesterday...
Windows: support getting the thread name

Also organize the thread name tests a bit.
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2024

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2024
@RalfJung
Copy link
Member Author

RalfJung commented Mar 3, 2024

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

📌 Commit 639fab7 has been approved by RalfJung

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 3, 2024
@bors
Copy link
Collaborator

bors commented Mar 3, 2024

⌛ Testing commit 639fab7 with merge 279c9ba...

@bors
Copy link
Collaborator

bors commented Mar 3, 2024

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing 279c9ba to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 3, 2024
@bors bors merged commit 279c9ba into rust-lang:master Mar 3, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 3, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (279c9ba): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.9% [1.9%, 1.9%] 1
Regressions ❌
(secondary)
3.2% [3.2%, 3.2%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.9% [1.9%, 1.9%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 649.996s -> 649.358s (-0.10%)
Artifact size: 175.05 MiB -> 175.04 MiB (-0.00%)

@RalfJung RalfJung deleted the miri branch March 4, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants