Skip to content

Conversation

@chenyukang
Copy link
Member

Fixes #121425

By the way, fix the spans for the argument in the second commit.

@rustbot
Copy link
Collaborator

rustbot commented Mar 2, 2024

r? @wesleywiser

rustbot has assigned @wesleywiser.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 2, 2024
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a verb conjugation nit, r=me after!

@compiler-errors
Copy link
Member

r? compiler-errors @rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2024
@chenyukang chenyukang force-pushed the yukang-fix-121425-repr-pack-error branch from 54e61d7 to 53dba7f Compare March 3, 2024 02:48
@chenyukang
Copy link
Member Author

@rustbot r=compiler-errors

@chenyukang
Copy link
Member Author

@bors r=compiler-errors

@bors
Copy link
Collaborator

bors commented Mar 4, 2024

📌 Commit 53dba7f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 4, 2024
@bors
Copy link
Collaborator

bors commented Mar 4, 2024

⌛ Testing commit 53dba7f with merge f7cb53e...

@bors
Copy link
Collaborator

bors commented Mar 4, 2024

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing f7cb53e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2024
@bors bors merged commit f7cb53e into rust-lang:master Mar 4, 2024
@rustbot rustbot added this to the 1.78.0 milestone Mar 4, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f7cb53e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.3% [0.5%, 2.1%] 2
Improvements ✅
(primary)
-3.1% [-3.7%, -2.6%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.1% [-3.7%, -2.6%] 2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 643.294s -> 643.541s (0.04%)
Artifact size: 175.02 MiB -> 175.00 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Misleading error message when using a named constant as a struct alignment

6 participants