Skip to content

Conversation

@bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Nov 16, 2023

The main highlights this time are support for AES and SHA256 crypto intrinsics on x86_64 by lowering to inline asm.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

bjorn3 and others added 18 commits November 10, 2023 11:30
Now that cranelift is distributed with Rustup, I find myself constantly searching for the rust-lang#81746 PR. I think that it would be useful to also describe the Rustup installation/usage instructions here in README.
Add Rustup installation instructions to README
This is a lot more compact and significantly faster
…line_asm

Implement AES-NI and SHA256 crypto intrinsics using inline asm
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2023
@rustbot

This comment was marked as resolved.

@rustbot rustbot added A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend labels Nov 16, 2023
@bjorn3 bjorn3 removed the has-merge-commits PR has merge commits, merge with caution. label Nov 16, 2023
@bjorn3
Copy link
Member Author

bjorn3 commented Nov 16, 2023

@bors r+ p=1 subtree sync

@bors
Copy link
Collaborator

bors commented Nov 16, 2023

📌 Commit 4db95ce has been approved by bjorn3

It is now in the queue for this repository.

@bors bors removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 16, 2023
@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Nov 16, 2023
@bors
Copy link
Collaborator

bors commented Nov 17, 2023

⌛ Testing commit 4db95ce with merge 15a791f...

@bors
Copy link
Collaborator

bors commented Nov 17, 2023

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 15a791f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 17, 2023
@bors bors merged commit 15a791f into rust-lang:master Nov 17, 2023
@rustbot rustbot added this to the 1.76.0 milestone Nov 17, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (15a791f): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.1% [-1.1%, -1.1%] 2
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -1.1% [-1.1%, -1.1%] 2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
0.6% [0.6%, 0.6%] 1
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 0.6% [0.6%, 0.6%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 675.999s -> 674.777s (-0.18%)
Artifact size: 313.63 MiB -> 313.65 MiB (0.01%)

@bjorn3 bjorn3 deleted the sync_cg_clif-2023-11-16 branch November 17, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-codegen Area: Code generation A-cranelift Things relevant to the [future] cranelift backend merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants