Linker: use -z <params> instead of -z<params>

[jedisct1]

The GNU linker accepts -z, but this is undocumented, and not supported by other linkers.

In particular, zig cc, when used as the C compiler/linker (e.g. when using cargo-zigbuild), will not accept this undocumented syntax.

In linker.rs, both syntaxes are also used inconsistently.

The Go compiler used to have the same issue, but fixed it:

golang/go@38607c5

[rustbot]

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

[wesleywiser]

Thanks @jedisct1! I can't think of any reason we wouldn't want to use the documented syntax in this case, even if the current version works for ld/lld.

Marking this as rollup=never to make it easier to bisect if there is fallout.

[wesleywiser]

@bors r+ rollup=never

[bors]

📌 Commit 8e250c3 has been approved by wesleywiser

It is now in the queue for this repository.

[bors]

⌛ Testing commit 8e250c3 with merge 246eae2...

[bors]

☀️ Test successful - checks-actions
Approved by: wesleywiser
Pushing 246eae2 to master...

[rust-timer]

Finished benchmarking commit (246eae2): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.1%	[-1.1%, -1.1%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.1%	[4.1%, 4.1%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.9%	[-0.9%, -0.9%]	1
All ❌✅ (primary)	4.1%	[4.1%, 4.1%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.8%	[2.8%, 2.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0