Stop using BREAK & CONTINUE in compiler
#107023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Switching them to `Break(())` and `Continue(())` instead. libs-api would like to remove these constants, so stop using them in compiler to make the removal PR later smaller.
Collaborator
|
r? @Nilstrieb (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
Collaborator
|
Some changes occurred in cc @BoxyUwU Some changes occurred to the CTFE / Miri engine cc @rust-lang/miri |
Noratrieb
reviewed
Jan 18, 2023
Member
Noratrieb
left a comment
Noratrieb
left a comment
There was a problem hiding this comment.
Looks good, can you also remove the #![feature] annotations for it?
Member
Author
|
It's the same gate as |
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 18, 2023
Stop using `BREAK` & `CONTINUE` in compiler Switching them to `Break(())` and `Continue(())` instead. Entirely search-and-replace, though there's one spot where rustfmt insisted on a reformatting too. libs-api would like to remove these constants (rust-lang#102697 (comment)), so stop using them in compiler to make the removal PR later smaller.
Member
Author
Yeah, I rather like them too -- after all, I started this by trying to stabilize them -- but I can't really argue against the "but we don't have |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 19, 2023
…mpiler-errors Rollup of 8 pull requests Successful merges: - rust-lang#105796 (rustdoc: simplify JS search routine by not messing with lev distance) - rust-lang#106753 (Make sure that RPITITs are not considered suggestable) - rust-lang#106917 (Encode const mir for closures if they're const) - rust-lang#107004 (Implement some candidates for the new solver (redux)) - rust-lang#107023 (Stop using `BREAK` & `CONTINUE` in compiler) - rust-lang#107030 (Correct typo) - rust-lang#107042 (rustdoc: fix corner cases with "?" JS keyboard command) - rust-lang#107045 (rustdoc: remove redundant CSS rule `#settings .setting-line`) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
scottmcm
added a commit
to scottmcm/rust
that referenced
this pull request
Jan 28, 2023
Libs-API decided to remove these in rust-lang#102697. Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 28, 2023
Remove `ControlFlow::{BREAK, CONTINUE}`
Libs-API decided to remove these in rust-lang#102697.
Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged.
r? libs
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Feb 10, 2023
Remove `ControlFlow::{BREAK, CONTINUE}`
Libs-API decided to remove these in rust-lang#102697.
Follow-up to rust-lang#107023, which removed them from `compiler/`, but a couple new ones showed up since that was merged.
r? libs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switching them to
Break(())andContinue(())instead.Entirely search-and-replace, though there's one spot where rustfmt insisted on a reformatting too.
libs-api would like to remove these constants (#102697 (comment)), so stop using them in compiler to make the removal PR later smaller.