Make a time test less flaky #10447
Closed
Make a time test less flaky #10447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test was failing periodically on windows and other platforms, and in debugging the issue locally I've found that the previous test was failing at the assertion `ns0 <= ns1`. Upon inspecting the values, the two numbers were very close to one another, but off by a little bit. I believe that this is because `precise_time_s` goes from `u64` -> `f64` and then we go again back to `u64` for the assertion. This conversion is a lossy one that's not always guaranteed to succeed, so instead I've changed the test to only compare against u64 instances.
bors
added a commit
that referenced
this pull request
Nov 13, 2013
This test was failing periodically on windows and other platforms, and in debugging the issue locally I've found that the previous test was failing at the assertion `ns0 <= ns1`. Upon inspecting the values, the two numbers were very close to one another, but off by a little bit. I believe that this is because `precise_time_s` goes from `u64` -> `f64` and then we go again back to `u64` for the assertion. This conversion is a lossy one that's not always guaranteed to succeed, so instead I've changed the test to only compare against u64 instances.
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Mar 24, 2023
…lon, r=giraffate Fix semicolon insertion in `match_single_binding` changelog: [`match_single_binding`]: Fix missing semicolon after the suggestion Fixes rust-lang#10447 Also fixes an edge case for unit returning macros in expression contexts: ```rust f(match 1 { _ => println!("foo"), }); ``` would suggest ```rust f(println!("foo");); ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was failing periodically on windows and other platforms, and in
debugging the issue locally I've found that the previous test was failing
at the assertion
ns0 <= ns1. Upon inspecting the values, the two numbers werevery close to one another, but off by a little bit.
I believe that this is because
precise_time_sgoes fromu64->f64andthen we go again back to
u64for the assertion. This conversion is a lossy onethat's not always guaranteed to succeed, so instead I've changed the test to
only compare against u64 instances.