Skip to content

Replaced empty destructors with NonCopyable #7427 #10134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 29, 2013
Merged

Replaced empty destructors with NonCopyable #7427 #10134

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
83cdae6
Replaced empty destructors with NonCopyable #7427
reedlepee123 Oct 28, 2013
b7e9b0c
Added the comment #7427
reedlepee123 Oct 28, 2013
6e07377
Changed name to non_copyable #7427
reedlepee123 Oct 29, 2013
33b9afa
updated the places where the struct is created #7427
reedlepee123 Oct 29, 2013
6978137
Indentation
reedlepee123 Oct 29, 2013
b5e0738
removed extra line
reedlepee123 Oct 29, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/libsyntax/parse/parser.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,8 @@ pub fn Parser(sess: @mut ParseSess,
quote_depth: @mut 0,
obsolete_set: @mut HashSet::new(),
mod_path_stack: @mut ~[],
open_braces: @mut ~[]
open_braces: @mut ~[],
non_copyable: util::NonCopyable
}
}

Expand Down Expand Up @@ -339,13 +340,9 @@ pub struct Parser {
/// Used to determine the path to externally loaded source files
mod_path_stack: @mut ~[@str],
/// Stack of spans of open delimiters. Used for error message.
open_braces: @mut ~[Span]
}

#[unsafe_destructor]
impl Drop for Parser {
open_braces: @mut ~[Span],
/* do not copy the parser; its state is tied to outside state */
fn drop(&mut self) {}
priv non_copyable: util::NonCopyable
}

fn is_plain_ident_or_underscore(t: &token::Token) -> bool {
Expand Down