-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Fix alloc_instead_of_core
FP when alloc
is an alias
#15581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lintcheck changes for 8f3c6ac
This comment will be updated if you push new changes |
I kind of think we should suggest using |
That's not going to be easily doable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only thing that needs to be checked is that the first segment resolves to a crate. This should be done before matching on the name since std
and alloc
both have this issue.
This comment has been minimized.
This comment has been minimized.
This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
@Jarcho Updated. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Closes #15579
changelog:
alloc_instead_of_core
fix FP whenalloc
is an alias