Skip to content

Conversation

profetia
Copy link
Contributor

@profetia profetia commented Aug 27, 2025

Closes #15579

changelog: alloc_instead_of_core fix FP when alloc is an alias

@rustbot
Copy link
Collaborator

rustbot commented Aug 27, 2025

r? @Jarcho

rustbot has assigned @Jarcho.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Aug 27, 2025
Copy link

github-actions bot commented Aug 27, 2025

Lintcheck changes for 8f3c6ac

Lint Added Removed Changed
clippy::alloc_instead_of_core 0 1 0
clippy::std_instead_of_core 0 0 2

This comment will be updated if you push new changes

@zihan0822
Copy link
Contributor

I kind of think we should suggest using core::alloc::Layout instead of skipping this lint for alloc::Layout.

@Jarcho
Copy link
Contributor

Jarcho commented Aug 28, 2025

That's not going to be easily doable. std::alloc is a module actually defined in std which re-exports everything in alloc::alloc. std::fmt, std::collections and others have the same issue.

Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only thing that needs to be checked is that the first segment resolves to a crate. This should be done before matching on the name since std and alloc both have this issue.

View changes since this review

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties labels Aug 29, 2025
@rustbot

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Aug 31, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@profetia
Copy link
Contributor Author

@Jarcho Updated. Thank you!

@profetia profetia requested a review from Jarcho August 31, 2025 19:35
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties and removed S-waiting-on-author Status: This is awaiting some action from the author. (Use `@rustbot ready` to update this status) labels Aug 31, 2025
@profetia profetia requested a review from Jarcho September 1, 2025 00:03
Copy link
Contributor

@Jarcho Jarcho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jarcho Jarcho added this pull request to the merge queue Sep 2, 2025
Merged via the queue into rust-lang:master with commit d97640c Sep 2, 2025
11 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alloc-instead-of-core there is no core::Layout
4 participants