Fix FP of needless_range_loop when meeting multidimensional array
#15486
+86
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Jarcho
requested changes
Aug 15, 2025
rustbot
added
S-waiting-on-author
relaxcn
force-pushed
the
nrl
branch
2 times, most recently
from
d647bf9 to
afb5ebb
Compare
|
@rustbot ready |
rustbot
added
S-waiting-on-review
Jarcho
reviewed
Aug 29, 2025
| @@ -320,7 +346,7 @@ impl<'tcx> Visitor<'tcx> for VarVisitor<'_, 'tcx> { | |||
| .and_then(|def_id| self.cx.tcx.trait_of_assoc(def_id)) | |||
| && ((meth.ident.name == sym::index && self.cx.tcx.lang_items().index_trait() == Some(trait_id)) | |||
| || (meth.ident.name == sym::index_mut && self.cx.tcx.lang_items().index_mut_trait() == Some(trait_id))) | |||
| && !self.check(args_1, args_0, expr) | |||
| && !self.check(args_1, args_0, expr) | |||
There was a problem hiding this comment.
nit: formatting error. The earlier comment causes rustfmt to give up. I would just delete it since it doesn't really say anything useful.
There was a problem hiding this comment.
Is it a bug in rustfmt?
There was a problem hiding this comment.
It doesn't handle comments inside an expression.
There was a problem hiding this comment.
Thank you for your explanation.
I have deleted the comment and performed fmt command.
rustbot
removed
the
S-waiting-on-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15068
changelog: Fix [
needless_range_loop] false positive and false negative when meeting multidimensional array