Skip to content

Migrate path transform #20303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 28, 2025
Merged

Migrate path transform #20303

merged 2 commits into from
Jul 28, 2025

Conversation

Hmikihiro
Copy link
Contributor

@Hmikihiro Hmikihiro commented Jul 26, 2025 •
edited
Loading

part of #15710 and #18285

I replace ted in PathTransform. PathTransform::applay(&self, node) generates and return a new transformed node instead of modify the node passed.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 26, 2025
ShoyuVanilla
ShoyuVanilla approved these changes Jul 28, 2025
View reviewed changes
Copy link
Member

@ShoyuVanilla ShoyuVanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It would be ideal to replace remaining .clone_for_update() from the migrate codes in future, but still great improvement 👍

@ShoyuVanilla ShoyuVanilla added this pull request to the merge queue Jul 28, 2025
Merged via the queue into rust-lang:master with commit 3a0cf54 Jul 28, 2025
15 checks passed
@rustbot rustbot removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShoyuVanilla ShoyuVanilla ShoyuVanilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Hmikihiro @ShoyuVanilla @rustbot