Move loaded project MSRV back to 1.78, show notification for the warning #19308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Veykril
changed the title
|
I think it's fine either way, but most (?) of the reports were from users who didn't mean to use an old toolchain. |
|
Yes but I don't think we have to be too aggressive with this here (likewise for some decisions in the past), the code here is not really a maintenance burden. |
|
I also want to pop a notification for our MSRV check, as people do not seem to notice the warning otherwise and then bumping aggressively isn't that great. |
Veykril
force-pushed
the
push-rnrxutwlvmly
branch
from
af020e2 to
1427a91
Compare
Veykril
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldve probably rolled that back from the start when we noticed this